Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2305043002: Removing .gyp/.gypi files from the mojo/ folder. (Closed)

Created:
4 years, 3 months ago by yzshen1
Modified:
4 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing .gyp/.gypi files from the mojo/ folder. BUG=None Committed: https://crrev.com/69f5de1c59d12aa1149ca81157368f026ac0ce46 Cr-Commit-Position: refs/heads/master@{#416351}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2249 lines) Patch
D mojo/mojo.gyp View 1 chunk +0 lines, -18 lines 0 comments Download
D mojo/mojo_base.gyp View 1 chunk +0 lines, -192 lines 0 comments Download
D mojo/mojo_edk.gyp View 1 chunk +0 lines, -233 lines 0 comments Download
D mojo/mojo_edk.gypi View 1 chunk +0 lines, -121 lines 0 comments Download
D mojo/mojo_edk_nacl.gyp View 1 chunk +0 lines, -85 lines 0 comments Download
D mojo/mojo_edk_tests.gyp View 1 chunk +0 lines, -398 lines 0 comments Download
D mojo/mojo_public.gyp View 1 chunk +0 lines, -310 lines 0 comments Download
D mojo/mojo_public.gypi View 1 chunk +0 lines, -156 lines 0 comments Download
D mojo/mojo_public_nacl.gyp View 1 chunk +0 lines, -87 lines 0 comments Download
D mojo/mojo_public_tests.gyp View 1 chunk +0 lines, -163 lines 0 comments Download
D mojo/mojom_bindings_generator.gypi View 1 chunk +0 lines, -178 lines 0 comments Download
D mojo/mojom_bindings_generator_explicit.gypi View 1 chunk +0 lines, -195 lines 0 comments Download
D mojo/mojom_bindings_generator_variables.gypi View 1 chunk +0 lines, -29 lines 0 comments Download
D mojo/public/tools/bindings/bindings.gyp View 1 chunk +0 lines, -84 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
yzshen1
Hi, Ken. Would you please take a look? I just mechanically removed the files. I ...
4 years, 3 months ago (2016-09-02 20:46:07 UTC) #4
Ken Rockot(use gerrit already)
LGTM LGTM LGTM LGTM LGTM LGTM LGTM LGTM LGTM LGTM LGTM LGTM LGTM LGTM LGTM ...
4 years, 3 months ago (2016-09-02 21:03:39 UTC) #5
yzshen1
On 2016/09/02 21:03:39, Ken Rockot wrote: > LGTM LGTM LGTM LGTM LGTM LGTM LGTM LGTM ...
4 years, 3 months ago (2016-09-02 21:29:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2305043002/20001
4 years, 3 months ago (2016-09-02 21:30:48 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-02 21:36:09 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 21:38:30 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/69f5de1c59d12aa1149ca81157368f026ac0ce46
Cr-Commit-Position: refs/heads/master@{#416351}

Powered by Google App Engine
This is Rietveld 408576698