Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 230503005: CHECK that the frames that UserScriptScheduler gets are non-NULL. We're seeing (Closed)

Created:
6 years, 8 months ago by not at google - send to devlin
Modified:
6 years, 8 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

CHECK that the frames that UserScriptScheduler gets are non-NULL. We're seeing a crash which might be caused by this. BUG=360461 R=rdevlin.cronin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262800

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/renderer/extensions/user_script_scheduler.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
not at google - send to devlin
6 years, 8 months ago (2014-04-09 17:44:11 UTC) #1
Devlin
lgtm
6 years, 8 months ago (2014-04-09 19:38:50 UTC) #2
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 8 months ago (2014-04-09 19:39:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/230503005/1
6 years, 8 months ago (2014-04-09 19:40:32 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 20:40:34 UTC) #5
Message was sent while issue was closed.
Change committed as 262800

Powered by Google App Engine
This is Rietveld 408576698