Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 230503004: Don't show temporary patterns in chrome://settings/contentExceptions#zoomlevels (Closed)

Created:
6 years, 8 months ago by battre
Modified:
6 years, 8 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org
Visibility:
Public.

Description

Don't show temporary patterns in chrome://settings/contentExceptions#zoomlevels Scheme-and-host patterns are not persisted in the HostZoomMap and get cleared on the next browser restart. Therefore, they are not so privacy sensitive and don't need to be displayed in the content settings. BUG=361575 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263078

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -14 lines) Patch
M chrome/browser/ui/webui/options/content_settings_handler.cc View 3 chunks +3 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
battre
Hi Denis, this is an alterative solution to fixing 361575. I think it depends a ...
6 years, 8 months ago (2014-04-09 14:56:18 UTC) #1
Denis Kuznetsov (DE-MUC)
This one looks good to me. lgtm
6 years, 8 months ago (2014-04-10 12:34:33 UTC) #2
battre
On 2014/04/10 12:34:33, Denis Kuznetsov wrote: > This one looks good to me. > lgtm ...
6 years, 8 months ago (2014-04-10 12:55:57 UTC) #3
battre
Hi Dan, can I get your OWNER's approval for this? Thanks, Dominic
6 years, 8 months ago (2014-04-10 12:57:37 UTC) #4
Dan Beam
rs lgtm
6 years, 8 months ago (2014-04-10 18:40:49 UTC) #5
battre
The CQ bit was checked by battre@chromium.org
6 years, 8 months ago (2014-04-10 18:42:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/230503004/1
6 years, 8 months ago (2014-04-10 18:42:48 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 21:08:42 UTC) #8
Message was sent while issue was closed.
Change committed as 263078

Powered by Google App Engine
This is Rietveld 408576698