Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 230503003: Udev-related methods are extracted from HidServiceLinux into individual service. (Closed)

Created:
6 years, 8 months ago by ygorshenin1
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Udev-related methods are extracted from HidServiceLinux into an individual service. BUG=357050 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262993

Patch Set 1 #

Patch Set 2 : Cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -154 lines) Patch
A device/hid/device_monitor_linux.h View 1 1 chunk +60 lines, -0 lines 0 comments Download
A device/hid/device_monitor_linux.cc View 1 1 chunk +135 lines, -0 lines 0 comments Download
M device/hid/hid.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
M device/hid/hid_connection_linux.h View 1 chunk +4 lines, -1 line 0 comments Download
M device/hid/hid_service_linux.h View 1 1 chunk +8 lines, -48 lines 0 comments Download
M device/hid/hid_service_linux.cc View 5 chunks +21 lines, -105 lines 0 comments Download
A device/hid/udev_common.h View 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ygorshenin1
6 years, 8 months ago (2014-04-09 14:51:52 UTC) #1
Ken Rockot(use gerrit already)
LGTM in general. I would eventually like to see DeviceMonitor[Linux] have its own build target, ...
6 years, 8 months ago (2014-04-09 15:12:31 UTC) #2
ygorshenin1
Thank you, Ken! I had not planned to create similar services for mac and win, ...
6 years, 8 months ago (2014-04-09 17:53:07 UTC) #3
ygorshenin1
The CQ bit was checked by ygorshenin@chromium.org
6 years, 8 months ago (2014-04-10 10:49:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/230503003/20001
6 years, 8 months ago (2014-04-10 10:49:52 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 15:11:15 UTC) #6
Message was sent while issue was closed.
Change committed as 262993

Powered by Google App Engine
This is Rietveld 408576698