chrome/test/data/prerender/prerender_prefetch_image.html - Issue 2304953002: NoState Prefetch: nostate prefetch browser tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/prerender/prerender_prefetch_image.html

Issue 2304953002: NoState Prefetch: nostate prefetch browser tests. (Closed)

Patch Set: histogram tests Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/test/data/prerender/prerender_prefetch2.js ('K') | « chrome/test/data/prerender/prerender_prefetch2.js ('k') | chrome/test/data/prerender/prerender_prefetch_loader.html » ('j') | chrome/test/data/prerender/prerender_prefetch_subresource_redirect.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <!--

	3 This page checks for prefetching of a an image.
	pasko 2016/09/22 18:14:05 let's name the files like: chrome/test/data/prere let's name the files like: chrome/test/data/prerender/prefetch_image.html i.e. without the leading "prerender_" in the last component of the path. Most of other files read as if "prerender" is a verb, like "prerender_and_do_foo", so a consistent extension to this would be "prefetch_and_do_foo", and luckily we already have the word "prerender" in the path. mattcary 2016/09/23 09:00:15 Yeah, I was thinking about that. I started naming Show quoted text On 2016/09/22 18:14:05, pasko wrote: > let's name the files like: > > chrome/test/data/prerender/prefetch_image.html > > i.e. without the leading "prerender_" in the last component of the path. Most of > other files read as if "prerender" is a verb, like "prerender_and_do_foo", so a > consistent extension to this would be "prefetch_and_do_foo", and luckily we > already have the word "prerender" in the path. Yeah, I was thinking about that. I started naming them consistently with existing files, but all the prerender_prefetch_stuff is pretty silly.
	4 -->

	5 <head>

	6 <title>Prefetch Page</title>
	pasko 2016/09/22 18:14:05 please add consistent 2 space indentation in the n please add consistent 2 space indentation in the new html files. I know that not all files in this directory are doing it, but it really helps to clearly see that something is in head and something other is in body, for example. Not asking to do this for .cc files because .cc file names should be unique due to [...] reasons in various build systems. mattcary 2016/09/23 09:00:15 Done. Show quoted text On 2016/09/22 18:14:05, pasko wrote: > please add consistent 2 space indentation in the new html files. I know that not > all files in this directory are doing it, but it really helps to clearly see > that something is in head and something other is in body, for example. > > Not asking to do this for .cc files because .cc file names should be unique due > to [...] reasons in various build systems. Done.
	7 <script src="prerender_prefetch.js" type="text/javascript"></script>

	8 </head>

	9 <body>

	10 <img src="REPLACE_WITH_IMAGE_URL"/>

	11 </body>

	12 </html>

OLD	NEW