Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1195)

Unified Diff: src/wasm/wasm-debug.cc

Issue 2304943002: Do not call into JS from WasmDebugInfo::GetFunctionScript (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/wasm-debug.cc
diff --git a/src/wasm/wasm-debug.cc b/src/wasm/wasm-debug.cc
index f1b01593cf437415f2d4143af5e03734149a2851..d9ca0eb2b21e274c06575beec8bd67ca0d40220f 100644
--- a/src/wasm/wasm-debug.cc
+++ b/src/wasm/wasm-debug.cc
@@ -162,7 +162,10 @@ Script *WasmDebugInfo::GetFunctionScript(Handle<WasmDebugInfo> debug_info,
line_ends->set_map(isolate->heap()->fixed_cow_array_map());
script->set_line_ends(*line_ends);
- isolate->debug()->OnAfterCompile(script);
+ // TODO(clemensh): Register with the debugger. Note that we cannot call into
+ // JS at this point since this function is called from within stack trace
+ // collection (which means we cannot call Debug::OnAfterCompile in its
+ // current form).
titzer 2016/09/02 13:46:26 Can you keep the original line of code, but commen
return *script;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698