Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2304943002:
Do not call into JS from WasmDebugInfo::GetFunctionScript (Closed)
DescriptionDo not call into JS from WasmDebugInfo::GetFunctionScript
This disables notification of wasm script 'compilation' since
OnAfterCompile actually triggers a JS call (which is disallowed during
stack trace collection).
BUG=641065
Committed: https://crrev.com/300f4413eb1282910de883f596cc53baebb6ec42
Cr-Commit-Position: refs/heads/master@{#39139}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Address comments & update test #Patch Set 3 : Rebase #
Messages
Total messages: 22 (16 generated)
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jgruber@chromium.org changed reviewers: + titzer@chromium.org
https://codereview.chromium.org/2304943002/diff/1/src/wasm/wasm-debug.cc File src/wasm/wasm-debug.cc (right): https://codereview.chromium.org/2304943002/diff/1/src/wasm/wasm-debug.cc#newc... src/wasm/wasm-debug.cc:168: // current form). Can you keep the original line of code, but commented out or if(false)'d?
On 2016/09/02 13:46:27, titzer wrote: > https://codereview.chromium.org/2304943002/diff/1/src/wasm/wasm-debug.cc > File src/wasm/wasm-debug.cc (right): > > https://codereview.chromium.org/2304943002/diff/1/src/wasm/wasm-debug.cc#newc... > src/wasm/wasm-debug.cc:168: // current form). > Can you keep the original line of code, but commented out or if(false)'d? lgtm otherwise
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/8138) v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jgruber@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org Link to the patchset: https://codereview.chromium.org/2304943002/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Do not call into JS from WasmDebugInfo::GetFunctionScript This disables notification of wasm script 'compilation' since OnAfterCompile actually triggers a JS call (which is disallowed during stack trace collection). BUG=641065 ========== to ========== Do not call into JS from WasmDebugInfo::GetFunctionScript This disables notification of wasm script 'compilation' since OnAfterCompile actually triggers a JS call (which is disallowed during stack trace collection). BUG=641065 Committed: https://crrev.com/300f4413eb1282910de883f596cc53baebb6ec42 Cr-Commit-Position: refs/heads/master@{#39139} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/300f4413eb1282910de883f596cc53baebb6ec42 Cr-Commit-Position: refs/heads/master@{#39139} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
