Implemented printToSkPicture without using WebViewBenchmarkSupport.

cc/layers/content_layer.cc

 // Copyright 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/content_layer.h"
 
 #include "base/auto_reset.h"
 #include "base/metrics/histogram.h"
 #include "base/time/time.h"
 #include "cc/layers/content_layer_client.h"
@@ skipping 127 matching lines @@
 
   can_use_lcd_text_last_frame_ = can_use_lcd_text();
   if (client_)
     client_->DidChangeLayerCanUseLCDText();
 }
 
 bool ContentLayer::SupportsLCDText() const {
   return true;
 }
 
+
+skia::RefPtr<SkPicture> ContentLayer::GetPicture() const {

[enne (OOO), 2013/08/19 23:01:09]

It seems like you should also implement this in PictureLayer.

Would this also be useful to implement for PictureImageLayer as well?  I'm not
quite sure what the exact goals of this picture collection are.

It's not going to give the Skia team extra information, but if they are trying
to weigh out how frequently an optimization will help against all pictures the
compositor uses, it would be more balanced to include it.

[alokp, 2013/08/19 23:08:37]

Aren't PictureLayers created only if you are using impl-side painting? I am
re-implementing functionality that works even when not using impl-side painting.

At least for this iteration I do not want to change any functionality, which is
implemented here:
http://src.chromium.org/viewvc/blink/trunk/Source/web/WebViewBenchmarkSupport...

[enne (OOO), 2013/08/19 23:17:21]

Yes, PictureLayers are only created with impl-side painting.  However, it seems
like this benchmarking should continue to work regardless of whether or not
impl-side painting is turned on, which is why I suggested implementing this in
PictureLayer as well.
Ah, I see.  The previous code would skip image layers.

[alokp, 2013/08/19 23:37:20]

I missed the "as well" part and did not realize that PictureLayer is not derived
from ContentLayer. DONE.

+  if (!client_ || !DrawsContent())
+    return skia::RefPtr<SkPicture>();
+
+  int width = bounds().width();
+  int height = bounds().height();
+  gfx::RectF opaque;
+
+  skia::RefPtr<SkPicture> picture = skia::AdoptRef(new SkPicture);
+  SkCanvas* canvas = picture->beginRecording(width, height);
+  client_->PaintContents(canvas, gfx::Rect(width, height), &opaque);
+  picture->endRecording();
+  return picture;
+}
+
 }  // namespace cc