Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2304893002: [Telemetry] Switch ShouldTearDownStateAfterEachStoryRun to True as default (Closed)

Created:
4 years, 3 months ago by perezju
Modified:
4 years, 1 month ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Switch ShouldTearDownStateAfterEachStoryRun to True as default To reduce complexity of benchmarks and imcrease stability of measurements benchmarks will now tear down the state (i.e. restart the browser) between each page/story of a test. Perf sherfiffs warning: This CL is expected to affect measurements of many benchmarks. BUG=chromium:640990 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/4f812c9035e6cf9bad6774bb6ff71c1822167e0a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M telemetry/telemetry/benchmark.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
perezju
4 years, 3 months ago (2016-09-02 09:55:10 UTC) #2
nednguyen
lgtm Can you land on s.t like Saturday morning? :P
4 years, 3 months ago (2016-09-02 12:46:21 UTC) #7
perezju
On 2016/09/02 12:46:21, nednguyen wrote: > lgtm > > Can you land on s.t like ...
4 years, 3 months ago (2016-09-02 12:57:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2304893002/1
4 years, 3 months ago (2016-09-03 10:43:52 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/4f812c9035e6cf9bad6774bb6ff71c1822167e0a
4 years, 3 months ago (2016-09-03 10:45:30 UTC) #12
Ting-Yuan (Leo) Huang
This has made page_cycler much longer and telemetry_AFDOGenerate has been failing for more than a ...
4 years, 3 months ago (2016-09-09 23:21:37 UTC) #13
nednguyen
On 2016/09/09 23:21:37, Ting-Yuan (Leo) Huang wrote: > This has made page_cycler much longer and ...
4 years, 3 months ago (2016-09-10 02:25:08 UTC) #14
perezju
On 2016/09/09 23:21:37, Ting-Yuan (Leo) Huang wrote: > This has made page_cycler much longer and ...
4 years, 3 months ago (2016-09-12 09:55:12 UTC) #15
kirr
On 2016/09/12 09:55:12, perezju wrote: > On 2016/09/09 23:21:37, Ting-Yuan (Leo) Huang wrote: > > ...
4 years, 1 month ago (2016-11-03 12:13:23 UTC) #16
nednguyen
4 years, 1 month ago (2016-11-03 12:29:20 UTC) #17
Message was sent while issue was closed.
On 2016/11/03 12:13:23, kirr wrote:
> On 2016/09/12 09:55:12, perezju wrote:
> > On 2016/09/09 23:21:37, Ting-Yuan (Leo) Huang wrote:
> > > This has made page_cycler much longer and telemetry_AFDOGenerate has been
> > > failing for more than a week. Can we revert this for now?
> > 
> > Is there a bug tracking those issues? Maybe there are some other
alternatives
> we
> > should explore to address those.
> 
> Seems like results dispersion increased in many benchmarks:
>
https://chromeperf.appspot.com/report?sid=a58d71220e54f0ea0e23ca51e5ab586d1c0...

Yes. That's the price we have to pay for getting:
1) A more truthful version of "cold load"
2) Independence between test run --> this enables our bisect system to only
bisect on a single test in a benchmark.

Powered by Google App Engine
This is Rietveld 408576698