Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2304853002: Revert of Allow lexically declared "arguments" in function scope in sloppy mode. (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
Reviewers:
lpy, adamk, mythria
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Allow lexically declared "arguments" in function scope in sloppy mode. (patchset #5 id:100001 of https://codereview.chromium.org/2290753003/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/9470 Original issue's description: > Allow lexically declared "arguments" in function scope in sloppy mode. > > Lexically declared "arguments" in sloppy mode will throw redeclaration error > currently, this patch fixes it by delaying the declaration of arguments until we > fully parse parameter list and function body. > > BUG=v8:4577 > LOG=N > > Committed: https://crrev.com/70a613dd0a5f5d205b46559b55702764464851fa > Cr-Commit-Position: refs/heads/master@{#39109} TBR=adamk@chromium.org,mythria@chromium.org,lpy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4577 Committed: https://crrev.com/d67fedb12c7eb3d21cc77f422f1934d4817c4d43 Cr-Commit-Position: refs/heads/master@{#39115}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -375 lines) Patch
M src/ast/scopes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ast/scopes.cc View 3 chunks +9 lines, -23 lines 0 comments Download
M src/parsing/parser.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallLookupSlot.golden View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ContextVariables.golden View 1 chunk +260 lines, -263 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CreateRestParameter.golden View 1 chunk +7 lines, -7 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Eval.golden View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/LookupSlot.golden View 3 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M test/cctest/test-parsing.cc View 3 chunks +18 lines, -43 lines 0 comments Download
A test/mjsunit/bugs/bug-4577.js View 1 chunk +13 lines, -0 lines 0 comments Download
D test/mjsunit/regress/regress-4577.js View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of Allow lexically declared "arguments" in function scope in sloppy mode.
4 years, 3 months ago (2016-09-02 06:22:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2304853002/1
4 years, 3 months ago (2016-09-02 06:22:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 06:23:15 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 06:24:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d67fedb12c7eb3d21cc77f422f1934d4817c4d43
Cr-Commit-Position: refs/heads/master@{#39115}

Powered by Google App Engine
This is Rietveld 408576698