command buffers: correctly handle Flush(num_entries)

command buffers: correctly handle Flush(num_entries)

CommandBufferService should not accept put == num_entries, the client must
wraparound to 0 (CommandBufferHelper does).
CommandParser wraps to 0 and never sets get_ == num_entries, so
CommandParser::IsEmpty would never become true.

A test should have caught that but unfortunately it confused buffer size and
number of entries. This fixes it.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/792420d5f706198281b3dcc6c26d23d38b2afd91
Cr-Commit-Position: refs/heads/master@{#417211}

[piman, 2016-09-02 03:33:44]

Description was changed from

==========
command buffers: correctly handle Flush(num_entries)

CommandBufferService should not accept put == num_entries, the client must
wraparound to 0 (CommandBufferHelper does).
CommandParser wraps to 0 and never sets get_ == num_entries, so
CommandParser::IsEmpty would never become true.

A test should have caught that but unfortunately it confused buffer size and
number of entries. This fixes it.

BUG=None
==========

to

==========
command buffers: correctly handle Flush(num_entries)

CommandBufferService should not accept put == num_entries, the client must
wraparound to 0 (CommandBufferHelper does).
CommandParser wraps to 0 and never sets get_ == num_entries, so
CommandParser::IsEmpty would never become true.

A test should have caught that but unfortunately it confused buffer size and
number of entries. This fixes it.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[piman, 2016-09-02 03:33:47]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 03:33:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-09-02 03:35:33]

piman@chromium.org changed reviewers:
+ vmiura@chromium.org

[commit-bot: I haz the power, 2016-09-02 04:45:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 04:45:30]

Dry run: This issue passed the CQ dry run.

[piman, 2016-09-07 23:14:00]

ping?

[vmiura, 2016-09-08 04:29:06]

On 2016/09/07 23:14:00, piman wrote:
> ping?

LGTM .

[piman, 2016-09-08 04:30:05]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2016-09-08 04:30:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 06:54:40]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-08 06:58:05]

Description was changed from

==========
command buffers: correctly handle Flush(num_entries)

CommandBufferService should not accept put == num_entries, the client must
wraparound to 0 (CommandBufferHelper does).
CommandParser wraps to 0 and never sets get_ == num_entries, so
CommandParser::IsEmpty would never become true.

A test should have caught that but unfortunately it confused buffer size and
number of entries. This fixes it.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
command buffers: correctly handle Flush(num_entries)

CommandBufferService should not accept put == num_entries, the client must
wraparound to 0 (CommandBufferHelper does).
CommandParser wraps to 0 and never sets get_ == num_entries, so
CommandParser::IsEmpty would never become true.

A test should have caught that but unfortunately it confused buffer size and
number of entries. This fixes it.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/792420d5f706198281b3dcc6c26d23d38b2afd91
Cr-Commit-Position: refs/heads/master@{#417211}
==========

[commit-bot: I haz the power, 2016-09-08 06:58:06]

Patchset 1 (id:??) landed as
https://crrev.com/792420d5f706198281b3dcc6c26d23d38b2afd91
Cr-Commit-Position: refs/heads/master@{#417211}