Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2304763002: Cleanup ui/views aura build configuration. (Closed)

Created:
4 years, 3 months ago by sunnyps
Modified:
4 years, 3 months ago
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup ui/views aura build configuration. ui/views would only build with x11 if use_atk was true. R=brettw@chromium.org BUG=643412 Committed: https://crrev.com/ac7e772253dcde9e24c67e817a0cb568263c90f5 Cr-Commit-Position: refs/heads/master@{#416769}

Patch Set 1 #

Patch Set 2 : Cleanup ui/views aura build configuration. #

Patch Set 3 : Cleanup ui/views aura build configuration. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M ui/views/BUILD.gn View 1 2 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
sunnyps
PTAL
4 years, 3 months ago (2016-09-02 01:06:11 UTC) #4
Mostyn Bramley-Moore
non-owner lgtm.
4 years, 3 months ago (2016-09-02 08:15:25 UTC) #8
sunnyps
ping
4 years, 3 months ago (2016-09-06 22:22:50 UTC) #9
brettw
LGTM. In the future, just ask local owners for //ui or //ui/views for this kind ...
4 years, 3 months ago (2016-09-06 22:24:12 UTC) #10
sunnyps
Sure. Thanks!
4 years, 3 months ago (2016-09-06 22:26:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2304763002/40001
4 years, 3 months ago (2016-09-06 22:27:24 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-06 23:27:04 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 23:30:48 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ac7e772253dcde9e24c67e817a0cb568263c90f5
Cr-Commit-Position: refs/heads/master@{#416769}

Powered by Google App Engine
This is Rietveld 408576698