Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 230473007: Remove obsolete GYP_MSVS_VERSION settings from buildbot configs (Closed)

Created:
6 years, 8 months ago by scottmg
Modified:
6 years, 8 months ago
Reviewers:
iannucci
CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Visibility:
Public.

Description

Remove obsolete GYP_MSVS_VERSION settings from buildbot configs The msvs version is controlled by hashes in the src/ tree now. R=iannucci@chromium.org BUG=309197 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=263122

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -213 lines) Patch
M masters/master.chromium.lkgr/master_lkgr_cfg.py View 1 chunk +0 lines, -1 line 0 comments Download
M masters/master.chromium.perf/master.cfg View 2 chunks +2 lines, -2 lines 0 comments Download
M masters/master.chromium.swarm/master.cfg View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M masters/master.chromium.webkit/master_win_webkit_latest_cfg.py View 2 chunks +0 lines, -2 lines 0 comments Download
M masters/master.chromium.win/master_win_cfg.py View 2 chunks +0 lines, -2 lines 0 comments Download
M masters/master.client.nacl.sdk/master.cfg View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M masters/master.tryserver.chromium/master.cfg View 2 chunks +1 line, -2 lines 0 comments Download
M scripts/master/factory/chromium_factory.py View 1 chunk +0 lines, -2 lines 0 comments Download
M scripts/master/factory/syzygy_factory.py View 1 chunk +0 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.py View 2 chunks +0 lines, -4 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/compile_failure_win.json View 3 chunks +3 lines, -5 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_win_blink_compile_dbg.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_win_blink_compile_rel.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_win_blink_dbg_fail.json View 3 chunks +3 lines, -5 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_win_blink_dbg_pass.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_win_blink_rel_fail.json View 3 chunks +3 lines, -5 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_win_blink_rel_pass.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_chromium_win_blink_compile.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_chromium_win_blink_compile_rel.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_chromium_win_blink_fail.json View 3 chunks +3 lines, -5 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_chromium_win_blink_pass.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_chromium_win_blink_rel_fail.json View 3 chunks +3 lines, -5 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/full_tryserver_chromium_win_blink_rel_pass.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Win.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_git_WinGit.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_git_WinGitXP.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder__dbg_.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_Builder.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_Builder__dbg_.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_failure.json View 3 chunks +3 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/gclient_revert_failure.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/gclient_revert_failure_win.json View 5 chunks +5 lines, -9 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/gclient_runhooks_failure.json View 3 chunks +3 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/invalid_json_without_patch.json View 3 chunks +3 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/win_debug.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/win_release.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/dart/dartium.expected/basic_win_64_MirrorFalse.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/dart/dartium.expected/basic_win_64_MirrorTrue.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_debug.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_debug_blink.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_debug_tryserver.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_release.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_release_blink.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_release_tryserver.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/win_debug.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/win_release.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/win_release_tot_angle.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/oilpan.expected/basic_win.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___1.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___2.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___debug___1.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___debug___2.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___debug___3.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___nosnap___shared.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_rel.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/v8.expected/try_compile_failure.json View 3 chunks +3 lines, -5 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__large_tests_.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_baremetal.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_rel.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_rel.json View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
6 years, 8 months ago (2014-04-10 22:47:49 UTC) #1
iannucci
woohoo! deleted code lgtm! There's probably a build_internal change too, to update the expectations.
6 years, 8 months ago (2014-04-10 23:11:47 UTC) #2
scottmg
On 2014/04/10 23:11:47, iannucci wrote: > woohoo! deleted code lgtm! > > There's probably a ...
6 years, 8 months ago (2014-04-10 23:15:05 UTC) #3
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 8 months ago (2014-04-10 23:15:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/230473007/40001
6 years, 8 months ago (2014-04-10 23:15:20 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 23:16:53 UTC) #6
Message was sent while issue was closed.
Change committed as 263122

Powered by Google App Engine
This is Rietveld 408576698