Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 230473004: V8 Buildbot: Add the ability to disable tests in nosnap mode. (Closed)

Created:
6 years, 8 months ago by Michael Achenbach
Modified:
6 years, 8 months ago
Reviewers:
dcarney
CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org
Visibility:
Public.

Description

V8 Buildbot: Add the ability to disable tests in nosnap mode. Depends on https://codereview.chromium.org/230743002/. BUG=v8:3216 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=262677

Patch Set 1 #

Messages

Total messages: 5 (0 generated)
Michael Achenbach
PTAL
6 years, 8 months ago (2014-04-09 12:39:26 UTC) #1
dcarney
lgtm
6 years, 8 months ago (2014-04-09 12:59:24 UTC) #2
Michael Achenbach
The CQ bit was checked by machenbach@chromium.org
6 years, 8 months ago (2014-04-09 12:59:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/230473004/1
6 years, 8 months ago (2014-04-09 12:59:45 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 13:00:44 UTC) #5
Message was sent while issue was closed.
Change committed as 262677

Powered by Google App Engine
This is Rietveld 408576698