Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2304723003: [swarming] Remove unnecessary dynamic libraries from isolate (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, Michael Achenbach
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[swarming] Remove unnecessary dynamic libraries from isolate The isolate driver finds dlls automatically. Hardcoding them blocks gn as the locations change. Prepares for https://codereview.chromium.org/2303233002/ BUG=chromium:474921 NOTRY=true TBR=jochen,vogelheim Committed: https://crrev.com/9521a5d609a0510fd54ed622b27945faa5d152a4 Cr-Commit-Position: refs/heads/master@{#39125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -78 lines) Patch
D gypfiles/config/win/msvs_dependencies.isolate View 1 chunk +0 lines, -77 lines 0 comments Download
M src/base.isolate View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Michael Achenbach
PTAL
4 years, 3 months ago (2016-09-02 10:02:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2304723003/1
4 years, 3 months ago (2016-09-02 10:32:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 10:34:28 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 10:35:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9521a5d609a0510fd54ed622b27945faa5d152a4
Cr-Commit-Position: refs/heads/master@{#39125}

Powered by Google App Engine
This is Rietveld 408576698