Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Side by Side Diff: tools/perf/benchmarks/smoothness.py

Issue 2304703003: perf: Don't record first_gesture_scroll_update_latency in smoothness.tough_ad_cases (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import multiprocessing 4 import multiprocessing
5 5
6 from core import perf_benchmark 6 from core import perf_benchmark
7 7
8 from benchmarks import silk_flags 8 from benchmarks import silk_flags
9 from measurements import smoothness 9 from measurements import smoothness
10 import page_sets 10 import page_sets
(...skipping 441 matching lines...) Expand 10 before | Expand all | Expand 10 after
452 page_set = page_sets.SyntheticToughAdCasesPageSet 452 page_set = page_sets.SyntheticToughAdCasesPageSet
453 453
454 @classmethod 454 @classmethod
455 def Name(cls): 455 def Name(cls):
456 return 'smoothness.tough_ad_cases' 456 return 'smoothness.tough_ad_cases'
457 457
458 @classmethod 458 @classmethod
459 def ShouldDisable(cls, possible_browser): 459 def ShouldDisable(cls, possible_browser):
460 return cls.IsSvelte(possible_browser) # http://crbug.com/555089 460 return cls.IsSvelte(possible_browser) # http://crbug.com/555089
461 461
462 @classmethod
463 def ValueCanBeAddedPredicate(cls, value, is_first_result):
464 del is_first_result # unused
465 # These pages don't scroll so it's not necessary to measure input latency.
466 return value.name != 'first_gesture_scroll_update_latency'
467
462 468
463 # http://crbug.com/522619 (mac/win) 469 # http://crbug.com/522619 (mac/win)
464 @benchmark.Disabled('win', 'mac') 470 @benchmark.Disabled('win', 'mac')
465 class SmoothnessScrollingToughAdCases(_Smoothness): 471 class SmoothnessScrollingToughAdCases(_Smoothness):
466 """Measures rendering statistics while scrolling advertisements.""" 472 """Measures rendering statistics while scrolling advertisements."""
467 page_set = page_sets.ScrollingToughAdCasesPageSet 473 page_set = page_sets.ScrollingToughAdCasesPageSet
468 474
469 @classmethod 475 @classmethod
470 def ShouldDisable(cls, possible_browser): # http://crbug.com/597656 476 def ShouldDisable(cls, possible_browser): # http://crbug.com/597656
471 return (possible_browser.browser_type == 'reference' and 477 return (possible_browser.browser_type == 'reference' and
472 possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X') 478 possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X')
473 479
474 @classmethod 480 @classmethod
475 def Name(cls): 481 def Name(cls):
476 return 'smoothness.scrolling_tough_ad_cases' 482 return 'smoothness.scrolling_tough_ad_cases'
477 483
478 484
479 class SmoothnessToughWebGLAdCases(_Smoothness): 485 class SmoothnessToughWebGLAdCases(_Smoothness):
480 """Measures rendering statistics while scrolling advertisements.""" 486 """Measures rendering statistics while scrolling advertisements."""
481 page_set = page_sets.SyntheticToughWebglAdCasesPageSet 487 page_set = page_sets.SyntheticToughWebglAdCasesPageSet
482 488
483 @classmethod 489 @classmethod
484 def Name(cls): 490 def Name(cls):
485 return 'smoothness.tough_webgl_ad_cases' 491 return 'smoothness.tough_webgl_ad_cases'
486 492
487 @classmethod 493 @classmethod
488 def ShouldDisable(cls, possible_browser): 494 def ShouldDisable(cls, possible_browser):
489 return cls.IsSvelte(possible_browser) # http://crbug.com/574485 495 return cls.IsSvelte(possible_browser) # http://crbug.com/574485
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698