Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html "> | 1 <link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html "> |
| 2 <link rel="import" href="chrome://resources/cr_elements/icons.html"> | |
| 2 <link rel="import" href="chrome://resources/html/polymer.html"> | 3 <link rel="import" href="chrome://resources/html/polymer.html"> |
| 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> | 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> |
| 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> | |
| 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html"> | |
| 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml"> | 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml"> |
| 5 <link rel="import" href="/printing_page/cups_printers_browser_proxy.html"> | 8 <link rel="import" href="/printing_page/cups_printers_browser_proxy.html"> |
| 6 <link rel="import" href="/settings_shared_css.html"> | 9 <link rel="import" href="/settings_shared_css.html"> |
| 7 | 10 |
| 8 <dom-module id="add-printer-list"> | 11 <dom-module id="add-printer-list"> |
| 9 <template> | 12 <template> |
| 10 <style include="settings-shared"> | 13 <style include="settings-shared"> |
| 11 .list-frame { | 14 .list-frame { |
| 12 -webkit-padding-end: 0; | 15 -webkit-padding-end: 0; |
| 13 -webkit-padding-start: 0; | 16 -webkit-padding-start: 0; |
| (...skipping 10 matching lines...) Expand all Loading... | |
| 24 </array-selector> | 27 </array-selector> |
| 25 <template is="dom-repeat" items="[[printers]]"> | 28 <template is="dom-repeat" items="[[printers]]"> |
| 26 <paper-item class="list-item" on-tap="onSelect_"> | 29 <paper-item class="list-item" on-tap="onSelect_"> |
| 27 [[item.printerName]] [[item.printerModel]] | 30 [[item.printerName]] [[item.printerModel]] |
| 28 </paper-item> | 31 </paper-item> |
| 29 </template> | 32 </template> |
| 30 </div> | 33 </div> |
| 31 </template> | 34 </template> |
| 32 </dom-module> | 35 </dom-module> |
| 33 | 36 |
| 37 <dom-module id="drop-down-search-box"> | |
| 38 <template> | |
| 39 <style include="settings-shared"> | |
| 40 paper-input, | |
| 41 iron-dropdown { | |
|
michaelpg
2016/09/02 21:51:55
nit: alphabetize this maybe
xdai1
2016/09/02 23:39:13
Done.
| |
| 42 width: 270px; | |
| 43 } | |
| 44 | |
| 45 paper-input { | |
| 46 --paper-input-container-color: var(--google-grey-500); | |
| 47 --paper-input-container-input: { | |
| 48 font-size: inherit; | |
| 49 }; | |
| 50 } | |
| 51 | |
| 52 iron-dropdown .dropdown-content paper-item { | |
| 53 min-height: 40px; | |
| 54 } | |
| 55 </style> | |
| 56 <paper-input no-label-float on-tap="onTap_" on-input="onInputValueChanged_" | |
|
michaelpg
2016/09/02 21:51:55
could be a performance issue with re-running the f
xdai1
2016/09/02 23:39:13
It seems 'paper-input' doesn't have on-search even
michaelpg
2016/09/06 22:24:40
Acknowledged.
Dan Beam
2016/09/06 22:37:12
it does if you do this:
https://cs.chromium.org/ch
michaelpg
2016/09/06 22:58:52
hmm, the difference between that and xdai1's lates
xdai1
2016/09/06 23:13:16
Thanks for the explanation.
| |
| 57 on-blur="onBlur_"> | |
| 58 <paper-icon-button suffix id="searchIcon" icon="cr:search" hidden> | |
| 59 </paper-icon-button> | |
| 60 <paper-icon-button suffix id="dropdownIcon" icon="cr:arrow-drop-down"> | |
| 61 </paper-icon-button> | |
| 62 </paper-input> | |
| 63 <iron-dropdown horizontal-align="left" vertical-align="top" | |
| 64 vertical-offset="47"> | |
|
michaelpg
2016/09/02 21:51:55
not a big fan of arbitrary numbers. will this work
xdai1
2016/09/02 23:39:13
It does work with scaling the page. I addressed yo
michaelpg
2016/09/06 22:24:40
yeah, that looks weird. If you couldn't find a pro
xdai1
2016/09/06 23:13:16
I don't find a proper way to dynamically determine
| |
| 65 <div class="dropdown-content"> | |
| 66 <template is="dom-repeat" items="[[items]]" | |
| 67 filter="[[filterItems_(searchTerm_)]]"> | |
| 68 <paper-item on-tap="onSelect_">[[item]]</paper-item> | |
| 69 </template> | |
| 70 </div> | |
| 71 </iron-dropdown> | |
| 72 </template> | |
| 73 </dom-module> | |
| 74 | |
| 34 <dom-module id="add-printer-dialog"> | 75 <dom-module id="add-printer-dialog"> |
| 35 <template> | 76 <template> |
| 36 <style include="settings-shared"> | 77 <style include="settings-shared"> |
| 37 #dialog .body { | 78 #dialog .body { |
| 38 -webkit-padding-end: 0; | 79 -webkit-padding-end: 0; |
| 39 -webkit-padding-start: 0; | 80 -webkit-padding-start: 0; |
| 40 height: 350px; | 81 height: 350px; |
| 41 } | 82 } |
| 42 | 83 |
| 43 #dialog .button-container { | 84 #dialog .button-container { |
| (...skipping 13 matching lines...) Expand all Loading... | |
| 57 <div class="body"> | 98 <div class="body"> |
| 58 <content select=".dialog-body"></content> | 99 <content select=".dialog-body"></content> |
| 59 </div> | 100 </div> |
| 60 <div class="button-container"> | 101 <div class="button-container"> |
| 61 <content select=".dialog-buttons"></content> | 102 <content select=".dialog-buttons"></content> |
| 62 </div> | 103 </div> |
| 63 </dialog> | 104 </dialog> |
| 64 </template> | 105 </template> |
| 65 <script src="cups_add_printer_dialog_util.js"></script> | 106 <script src="cups_add_printer_dialog_util.js"></script> |
| 66 </dom-module> | 107 </dom-module> |
| OLD | NEW |