Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2304643002: [Mac][Material Design] Fix regression in position of chevron icon. (Closed)

Created:
4 years, 3 months ago by shrike
Modified:
4 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac][Material Design] Fix regression in position of chevron icon. Fixes a regression with the chevron-overflow button caused by a recent cl that adjusted the location of bookmark button icons where there is no title title. R=avi@chromium.org BUG=640131 Committed: https://crrev.com/68058edebdc748f9df588a218ddce7fb90aa7635 Cr-Commit-Position: refs/heads/master@{#416016}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shrike
PTAL
4 years, 3 months ago (2016-09-01 18:43:40 UTC) #1
Avi (use Gerrit)
lgtm
4 years, 3 months ago (2016-09-01 18:44:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2304643002/1
4 years, 3 months ago (2016-09-01 18:46:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 19:29:46 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 19:32:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/68058edebdc748f9df588a218ddce7fb90aa7635
Cr-Commit-Position: refs/heads/master@{#416016}

Powered by Google App Engine
This is Rietveld 408576698