Fix various bugs in the type systems, and improve test coverage.

Fix various bugs in the type systems, and improve test coverage.

R=rossberg@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20609

[Benedikt Meurer, 2014-04-09 10:49:35]

PTAL

[rossberg, 2014-04-09 10:56:56]

LGTM with nits

https://codereview.chromium.org/230463003/diff/1/src/types.h
File src/types.h (right):

https://codereview.chromium.org/230463003/diff/1/src/types.h#newcode300
src/types.h:300: bool IsInhabited() {
Nit: move this up to line 222

https://codereview.chromium.org/230463003/diff/1/test/cctest/test-types.cc
File test/cctest/test-types.cc (right):

https://codereview.chromium.org/230463003/diff/1/test/cctest/test-types.cc#ne...
test/cctest/test-types.cc:104: for (int i = 0; i < 1000; ++i) {
We probably need to lower this somewhat. 500? 300?

https://codereview.chromium.org/230463003/diff/1/test/cctest/test-types.cc#ne...
test/cctest/test-types.cc:295: typedef typename Types<Type, TypeHandle,
Region>::TypeList::iterator
You should be able to say T::TypeList::iterator here; similarly below.

[Benedikt Meurer, 2014-04-09 11:12:26]

https://codereview.chromium.org/230463003/diff/1/src/types.h
File src/types.h (right):

https://codereview.chromium.org/230463003/diff/1/src/types.h#newcode300
src/types.h:300: bool IsInhabited() {
On 2014/04/09 10:56:56, rossberg wrote:
> Nit: move this up to line 222

Done.

https://codereview.chromium.org/230463003/diff/1/test/cctest/test-types.cc
File test/cctest/test-types.cc (right):

https://codereview.chromium.org/230463003/diff/1/test/cctest/test-types.cc#ne...
test/cctest/test-types.cc:104: for (int i = 0; i < 1000; ++i) {
300

https://codereview.chromium.org/230463003/diff/1/test/cctest/test-types.cc#ne...
test/cctest/test-types.cc:295: typedef typename Types<Type, TypeHandle,
Region>::TypeList::iterator
T does not name a type.

[Benedikt Meurer, 2014-04-09 11:13:01]

Committed patchset #2 manually as r20609 (presubmit successful).