Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2452)

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

Issue 230463002: Password bubble: Remove IconView from BubbleView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
index 1fdc271b442d898d3038dfe9ad5dcd0ef880a32d..d6d379e86a7e987e39d888758eb4f43160592249 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
@@ -83,7 +83,6 @@ ManagePasswordsBubbleView* ManagePasswordsBubbleView::manage_passwords_bubble_ =
// static
void ManagePasswordsBubbleView::ShowBubble(content::WebContents* web_contents,
- ManagePasswordsIconView* icon_view,
DisplayReason reason) {
Browser* browser = chrome::FindBrowserWithWebContents(web_contents);
DCHECK(browser);
@@ -96,7 +95,7 @@ void ManagePasswordsBubbleView::ShowBubble(content::WebContents* web_contents,
views::View* anchor_view = is_fullscreen ?
NULL : browser_view->GetLocationBarView()->manage_passwords_icon_view();
manage_passwords_bubble_ = new ManagePasswordsBubbleView(
- web_contents, anchor_view, icon_view, reason);
+ web_contents, anchor_view, reason);
if (is_fullscreen) {
manage_passwords_bubble_->set_parent_window(
@@ -130,13 +129,11 @@ bool ManagePasswordsBubbleView::IsShowing() {
ManagePasswordsBubbleView::ManagePasswordsBubbleView(
content::WebContents* web_contents,
views::View* anchor_view,
- ManagePasswordsIconView* icon_view,
DisplayReason reason)
: ManagePasswordsBubble(web_contents, reason),
BubbleDelegateView(anchor_view,
anchor_view ? views::BubbleBorder::TOP_RIGHT
- : views::BubbleBorder::NONE),
- icon_view_(icon_view) {
+ : views::BubbleBorder::NONE) {
// Compensate for built-in vertical padding in the anchor view's image.
set_anchor_view_insets(gfx::Insets(5, 0, 5, 0));
set_notify_enter_exit_on_child(true);
@@ -207,15 +204,11 @@ void ManagePasswordsBubbleView::AdjustForFullscreen(
}
void ManagePasswordsBubbleView::Close() {
- icon_view_->SetTooltip(model()->manage_passwords_bubble_state() ==
- ManagePasswordsBubbleModel::PASSWORD_TO_BE_SAVED);
GetWidget()->Close();
}
void ManagePasswordsBubbleView::CloseWithoutLogging() {
model()->OnCloseWithoutLogging();
- icon_view_->SetTooltip(model()->manage_passwords_bubble_state() ==
- ManagePasswordsBubbleModel::PASSWORD_TO_BE_SAVED);
GetWidget()->Close();
}

Powered by Google App Engine
This is Rietveld 408576698