Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 230463002: Password bubble: Remove IconView from BubbleView. (Closed)

Created:
6 years, 8 months ago by Mike West
Modified:
6 years, 8 months ago
Reviewers:
markusheintz_
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Password bubble: Remove IconView from BubbleView. The BubbleView currently holds a reference to the IconView in order to change its tooltip. We shouldn't do that; that should be taken care of by migrating the bubble view to a BubbleIconView, which will handle visibility changes and tooltop status. That will happen in a followup CL. BUG=261628 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265294

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -16 lines) Patch
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h View 1 3 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc View 1 4 chunks +2 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc View 1 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Mike West
Review plz? :) -mike
6 years, 8 months ago (2014-04-09 08:58:20 UTC) #1
markusheintz_
On 2014/04/09 08:58:20, Mike West wrote: > Review plz? :) > > -mike This is ...
6 years, 8 months ago (2014-04-10 13:04:51 UTC) #2
Mike West
On 2014/04/10 13:04:51, markusheintz_ wrote: > On 2014/04/09 08:58:20, Mike West wrote: > > Review ...
6 years, 8 months ago (2014-04-10 13:06:22 UTC) #3
markusheintz_
On 2014/04/10 13:06:22, Mike West wrote: > On 2014/04/10 13:04:51, markusheintz_ wrote: > > On ...
6 years, 8 months ago (2014-04-10 13:26:58 UTC) #4
markusheintz_
On 2014/04/10 13:26:58, markusheintz_ wrote: > On 2014/04/10 13:06:22, Mike West wrote: > > On ...
6 years, 8 months ago (2014-04-22 11:04:46 UTC) #5
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 8 months ago (2014-04-22 14:05:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/230463002/20001
6 years, 8 months ago (2014-04-22 14:05:55 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-22 14:27:03 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg
6 years, 8 months ago (2014-04-22 14:27:04 UTC) #9
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 8 months ago (2014-04-22 14:35:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/230463002/20001
6 years, 8 months ago (2014-04-22 14:35:49 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 17:20:56 UTC) #12
Message was sent while issue was closed.
Change committed as 265294

Powered by Google App Engine
This is Rietveld 408576698