Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 2304613002: Revert of [heap] Simplify heuristics for incremental step size. (Closed)

Created:
4 years, 3 months ago by ulan
Modified:
4 years, 3 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Simplify heuristics for incremental step size. (patchset #5 id:180001 of https://codereview.chromium.org/2290333002/ ) Reason for revert: Regressed GC times in v8.infinite_scroll_tbmv2 benchmarks. Original issue's description: > [heap] Simplify heuristics for incremental step size. > > This patch removes the code for speeding up marking. > > Now the step size depends on allocated bytes and > invoked write barriers. > > We also ensure that the step size is large enough to > justify the overhead of interrupting the generated code. > > BUG=chromium:616434 > LOG=NO > > Committed: https://crrev.com/71a793e4b1026e69d4009df0a419fe260fe1a235 > Cr-Commit-Position: refs/heads/master@{#39067} TBR=mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:616434 Committed: https://crrev.com/d09e026a9e5c5da7e6b7f2d4bc08f763cea36a18 Cr-Commit-Position: refs/heads/master@{#39098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -26 lines) Patch
M src/heap/heap.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/heap/incremental-marking.h View 4 chunks +20 lines, -6 lines 0 comments Download
M src/heap/incremental-marking.cc View 8 chunks +127 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ulan
Created Revert of [heap] Simplify heuristics for incremental step size.
4 years, 3 months ago (2016-09-01 17:28:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2304613002/1
4 years, 3 months ago (2016-09-01 17:28:41 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 17:28:49 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 17:29:49 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d09e026a9e5c5da7e6b7f2d4bc08f763cea36a18
Cr-Commit-Position: refs/heads/master@{#39098}

Powered by Google App Engine
This is Rietveld 408576698