src/full-codegen/ia32/full-codegen-ia32.cc - Issue 2304573004: Port FastCloneShallowArrayStub to Turbofan

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 2304573004: Port FastCloneShallowArrayStub to Turbofan (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: break live range of allocation_site so instruction selection uses nice addressing modes Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/ia32/full-codegen-ia32.cc

diff --git a/src/full-codegen/ia32/full-codegen-ia32.cc b/src/full-codegen/ia32/full-codegen-ia32.cc

index 8fde75830b434ec19c0651b5b5907241f8fc8c25..28164bd80acd403a2c24b1f99a441069aa17e107 100644

--- a/src/full-codegen/ia32/full-codegen-ia32.cc

+++ b/src/full-codegen/ia32/full-codegen-ia32.cc

@@ -1511,6 +1511,7 @@ void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) {

__ mov(ecx, Immediate(constant_elements));

FastCloneShallowArrayStub stub(isolate(), allocation_site_mode);

__ CallStub(&stub);

+ RestoreContext();

}

PrepareForBailoutForId(expr->CreateLiteralId(), BailoutState::TOS_REGISTER);