Port FastCloneShallowArrayStub to Turbofan

src/code-stubs.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_CODE_STUBS_H_
 #define V8_CODE_STUBS_H_
 
 #include "src/allocation.h"
 #include "src/assembler.h"
 #include "src/code-stub-assembler.h"
@@ skipping 50 matching lines @@
   /* They can be removed when only the TF  */ \
   /* version of the corresponding stub is  */ \
   /* used universally */                      \
   V(CallICTrampoline)                         \
   V(LoadICTrampoline)                         \
   V(KeyedLoadICTrampoline)                    \
   V(KeyedStoreICTrampoline)                   \
   V(StoreICTrampoline)                        \
   /* --- HydrogenCodeStubs --- */             \
   V(ElementsTransitionAndStore)               \
-  V(FastCloneShallowArray)                    \
   V(NumberToString)                           \
   V(StringAdd)                                \
   V(ToObject)                                 \
   V(Typeof)                                   \
   /* These builtins w/ JS linkage are */      \
   /* just fast-cases of C++ builtins. They */ \
   /* require varg support from TF */          \
   V(FastArrayPush)                            \
   V(FastFunctionBind)                         \
   /* These will be ported/eliminated */       \
@@ skipping 46 matching lines @@
   V(ShiftRight)                               \
   V(ShiftRightLogical)                        \
   V(ShiftLeft)                                \
   V(BitwiseAnd)                               \
   V(BitwiseOr)                                \
   V(BitwiseXor)                               \
   V(Inc)                                      \
   V(InternalArrayNoArgumentConstructor)       \
   V(InternalArraySingleArgumentConstructor)   \
   V(Dec)                                      \
+  V(FastCloneRegExp)                          \
+  V(FastCloneShallowArray)                    \
   V(FastCloneShallowObject)                   \
-  V(FastCloneRegExp)                          \
   V(FastNewClosure)                           \
   V(FastNewFunctionContext)                   \
   V(InstanceOf)                               \
   V(LessThan)                                 \
   V(LessThanOrEqual)                          \
   V(GreaterThan)                              \
   V(GreaterThanOrEqual)                       \
   V(Equal)                                    \
   V(NotEqual)                                 \
   V(KeyedLoadSloppyArguments)                 \
@@ skipping 1106 matching lines @@
                                   compiler::Node* literal_index,
                                   compiler::Node* pattern,
                                   compiler::Node* flags,
                                   compiler::Node* context);
 
  private:
   DEFINE_CALL_INTERFACE_DESCRIPTOR(FastCloneRegExp);
   DEFINE_TURBOFAN_CODE_STUB(FastCloneRegExp, TurboFanCodeStub);
 };
 
-
-class FastCloneShallowArrayStub : public HydrogenCodeStub {
+class FastCloneShallowArrayStub : public TurboFanCodeStub {
  public:
   FastCloneShallowArrayStub(Isolate* isolate,
                             AllocationSiteMode allocation_site_mode)
-      : HydrogenCodeStub(isolate) {
-    set_sub_minor_key(AllocationSiteModeBits::encode(allocation_site_mode));
+      : TurboFanCodeStub(isolate) {
+    minor_key_ = AllocationSiteModeBits::encode(allocation_site_mode);
   }
 
+  static compiler::Node* Generate(
+      CodeStubAssembler* assembler, compiler::Node* closure,
+      compiler::Node* literal_index, compiler::Node* constant_elements,
+      compiler::Node* context,
+      AllocationSiteMode allocation_site_mode = DONT_TRACK_ALLOCATION_SITE);

[rmcilroy, 2016/09/13 20:29:59]

no need for the default parameter here

[klaasb, 2016/09/14 18:24:52]

Done.

+
   AllocationSiteMode allocation_site_mode() const {
-    return AllocationSiteModeBits::decode(sub_minor_key());
+    return AllocationSiteModeBits::decode(minor_key_);
   }
 
  private:
   class AllocationSiteModeBits: public BitField<AllocationSiteMode, 0, 1> {};
 
+  static compiler::Node* NonEmptyShallowClone(

[rmcilroy, 2016/09/13 20:29:59]

This should probably just be an anonymous namespace function in the cc file
rather than a private static function in the class (seems to be the pattern for
other code stubs).

[klaasb, 2016/09/14 18:24:52]

Done.

+      CodeStubAssembler* assembler, compiler::Node* boilerplate,
+      compiler::Node* boilerplate_map, compiler::Node* boilerplate_elements,
+      compiler::Node* allocation_site, compiler::Node* capacity,
+      ElementsKind kind);
   DEFINE_CALL_INTERFACE_DESCRIPTOR(FastCloneShallowArray);
-  DEFINE_HYDROGEN_CODE_STUB(FastCloneShallowArray, HydrogenCodeStub);
+  DEFINE_TURBOFAN_CODE_STUB(FastCloneShallowArray, TurboFanCodeStub);
 };
 
 class FastCloneShallowObjectStub : public TurboFanCodeStub {
  public:
   // Maximum number of properties in copied object.
   static const int kMaximumClonedProperties = 6;
 
   FastCloneShallowObjectStub(Isolate* isolate, int length)
       : TurboFanCodeStub(isolate) {
     DCHECK_GE(length, 0);
@@ skipping 1912 matching lines @@
 #undef DEFINE_HYDROGEN_CODE_STUB
 #undef DEFINE_CODE_STUB
 #undef DEFINE_CODE_STUB_BASE
 
 extern Representation RepresentationFromMachineType(MachineType type);
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_CODE_STUBS_H_