Add ComputeMac and ComputeSplitMacs methods to pref_hash_store.

components/user_prefs/tracked/pref_hash_store_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_USER_PREFS_TRACKED_PREF_HASH_STORE_IMPL_H_
 #define COMPONENTS_USER_PREFS_TRACKED_PREF_HASH_STORE_IMPL_H_
 
 #include <memory>
 #include <string>
 
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "components/user_prefs/tracked/pref_hash_calculator.h"
 #include "components/user_prefs/tracked/pref_hash_store.h"
 
 class HashStoreContents;
 class PrefHashStoreTransaction;

[gab, 2016/09/01 21:21:56]

A bit of cleanup...

Anything that is only used by an override (and thus has to be
fwd-declared/included by interface header shouldn't be re-fwd-declared in impl
header).

So here, instead of adding new fwd-decls from pref_hash_store.h I'd say remove
these two fwd-decls as well as the include of <memory>

As-is we're kind of in an in-between where this CL is doing the right thing on
its own but creating a situation where we're nor re-fwd-declaring everything,
nor correctly not doing so...

[proberge, 2016/09/06 18:43:39]

Done.

 
 // Implements PrefHashStoreImpl by storing preference hashes in a
 // HashStoreContents.
 class PrefHashStoreImpl : public PrefHashStore {
  public:
   enum StoreVersion {
     // No hashes have been stored in this PrefHashStore yet.
     VERSION_UNINITIALIZED = 0,
     // The hashes in this PrefHashStore were stored before the introduction
     // of a version number and should be re-initialized.
@@ skipping 13 matching lines @@
 
   ~PrefHashStoreImpl() override;
 
   // Clears the contents of this PrefHashStore. |IsInitialized()| will return
   // false after this call.
   void Reset();
 
   // PrefHashStore implementation.
   std::unique_ptr<PrefHashStoreTransaction> BeginTransaction(
       std::unique_ptr<HashStoreContents> storage) override;
+  std::string ComputeMac(const std::string& path,
+                         const base::Value* new_value) override;
+  std::unique_ptr<base::DictionaryValue> ComputeSplitMacs(
+      const std::string& path,
+      const base::DictionaryValue* split_values) override;
 
  private:
   class PrefHashStoreTransactionImpl;
 
   const PrefHashCalculator pref_hash_calculator_;
   bool use_super_mac_;
 
   DISALLOW_COPY_AND_ASSIGN(PrefHashStoreImpl);
 };
 
 #endif  // COMPONENTS_USER_PREFS_TRACKED_PREF_HASH_STORE_IMPL_H_