Add DISABLE_CFI_PERF attribute on the methods with CFI checks disabled.

Add DISABLE_CFI_PERF attribute on the methods with CFI checks disabled.

Types converted in this CL:
LayoutBlock, LayoutBlockFlow, InlineFlowBox, InlineBox.

While we have not observed CFI to slowdown real-world use cases,
there are a few blink_perf microbenchmarks, which are somewhat affected
by the change. This change removes CFI protection from the methods
which contribute the most to the slowdown.

Eventually, when proposed optimizations in Clang are implemented
(https://crbug.com/638056, https://crbug.com/638064), these attributes
would be possible to remove from all/most of the methods.

This CL does not in fact change the list of disabled methods, it
just converts them from CFI blacklist entries into attributes.
This should increase visibility, and also serve as a guard against refactoring.

BUG=641536
Committed: https://crrev.com/5e2204ad64fdcbc8efc4d1cad26a9da5672a39a8
Cr-Commit-Position: refs/heads/master@{#416727}

[krasin1, 2016-09-01 18:46:43]

Description was changed from

==========
Add DISABLE_CFI_PERF attribute on the methods with CFI checks disabled.

Types converted: LayoutBlock.

While we have not observed CFI to slowdown real-world use cases,
there are a few blink_perf microbenchmarks, which are somewhat affected
by the change. This change removes CFI protection from the methods
which contribute the most to the slowdown.

Eventually, when proposed optimizations in Clang are implemented
(https://crbug.com/638056, https://crbug.com/638064), these attributes
would be possible to remove from all/most of the methods.

This CL does not in fact change the list of disabled methods, it
just converts them from CFI blacklist entries into attributes.
This should increase visibility, and also serve as a guard against refactoring.

BUG=641536
==========

to

==========
Add DISABLE_CFI_PERF attribute on the methods with CFI checks disabled.

Types converted: LayoutBlock, LayoutBlockFlow.

While we have not observed CFI to slowdown real-world use cases,
there are a few blink_perf microbenchmarks, which are somewhat affected
by the change. This change removes CFI protection from the methods
which contribute the most to the slowdown.

Eventually, when proposed optimizations in Clang are implemented
(https://crbug.com/638056, https://crbug.com/638064), these attributes
would be possible to remove from all/most of the methods.

This CL does not in fact change the list of disabled methods, it
just converts them from CFI blacklist entries into attributes.
This should increase visibility, and also serve as a guard against refactoring.

BUG=641536
==========

[krasin1, 2016-09-01 18:49:41]

Description was changed from

==========
Add DISABLE_CFI_PERF attribute on the methods with CFI checks disabled.

Types converted: LayoutBlock, LayoutBlockFlow.

While we have not observed CFI to slowdown real-world use cases,
there are a few blink_perf microbenchmarks, which are somewhat affected
by the change. This change removes CFI protection from the methods
which contribute the most to the slowdown.

Eventually, when proposed optimizations in Clang are implemented
(https://crbug.com/638056, https://crbug.com/638064), these attributes
would be possible to remove from all/most of the methods.

This CL does not in fact change the list of disabled methods, it
just converts them from CFI blacklist entries into attributes.
This should increase visibility, and also serve as a guard against refactoring.

BUG=641536
==========

to

==========
Add DISABLE_CFI_PERF attribute on the methods with CFI checks disabled.

Types converted: LayoutBlock, LayoutBlockFlow, InlineFlowBox.

While we have not observed CFI to slowdown real-world use cases,
there are a few blink_perf microbenchmarks, which are somewhat affected
by the change. This change removes CFI protection from the methods
which contribute the most to the slowdown.

Eventually, when proposed optimizations in Clang are implemented
(https://crbug.com/638056, https://crbug.com/638064), these attributes
would be possible to remove from all/most of the methods.

This CL does not in fact change the list of disabled methods, it
just converts them from CFI blacklist entries into attributes.
This should increase visibility, and also serve as a guard against refactoring.

BUG=641536
==========

[krasin1, 2016-09-01 18:54:44]

Description was changed from

==========
Add DISABLE_CFI_PERF attribute on the methods with CFI checks disabled.

Types converted: LayoutBlock, LayoutBlockFlow, InlineFlowBox.

While we have not observed CFI to slowdown real-world use cases,
there are a few blink_perf microbenchmarks, which are somewhat affected
by the change. This change removes CFI protection from the methods
which contribute the most to the slowdown.

Eventually, when proposed optimizations in Clang are implemented
(https://crbug.com/638056, https://crbug.com/638064), these attributes
would be possible to remove from all/most of the methods.

This CL does not in fact change the list of disabled methods, it
just converts them from CFI blacklist entries into attributes.
This should increase visibility, and also serve as a guard against refactoring.

BUG=641536
==========

to

==========
Add DISABLE_CFI_PERF attribute on the methods with CFI checks disabled.

Types converted in this CL:
LayoutBlock, LayoutBlockFlow, InlineFlowBox, InlineBox.

While we have not observed CFI to slowdown real-world use cases,
there are a few blink_perf microbenchmarks, which are somewhat affected
by the change. This change removes CFI protection from the methods
which contribute the most to the slowdown.

Eventually, when proposed optimizations in Clang are implemented
(https://crbug.com/638056, https://crbug.com/638064), these attributes
would be possible to remove from all/most of the methods.

This CL does not in fact change the list of disabled methods, it
just converts them from CFI blacklist entries into attributes.
This should increase visibility, and also serve as a guard against refactoring.

BUG=641536
==========

[krasin1, 2016-09-01 18:57:52]

krasin@chromium.org changed reviewers:
+ eae@chromium.org

[krasin1, 2016-09-01 18:57:53]

Hi Emil,

this is the second part of CFI blacklist -> DISABLE_CFI_PERF conversion. Please,
take a look!

[krasin1, 2016-09-01 22:41:14]

The CQ bit was checked by krasin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 22:42:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 00:18:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 00:18:18]

Dry run: This issue passed the CQ dry run.

[eae, 2016-09-05 20:53:43]

RS LGTM

[krasin1, 2016-09-06 17:10:02]

The CQ bit was checked by krasin@chromium.org

[commit-bot: I haz the power, 2016-09-06 17:10:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 21:00:41]

Description was changed from

==========
Add DISABLE_CFI_PERF attribute on the methods with CFI checks disabled.

Types converted in this CL:
LayoutBlock, LayoutBlockFlow, InlineFlowBox, InlineBox.

While we have not observed CFI to slowdown real-world use cases,
there are a few blink_perf microbenchmarks, which are somewhat affected
by the change. This change removes CFI protection from the methods
which contribute the most to the slowdown.

Eventually, when proposed optimizations in Clang are implemented
(https://crbug.com/638056, https://crbug.com/638064), these attributes
would be possible to remove from all/most of the methods.

This CL does not in fact change the list of disabled methods, it
just converts them from CFI blacklist entries into attributes.
This should increase visibility, and also serve as a guard against refactoring.

BUG=641536
==========

to

==========
Add DISABLE_CFI_PERF attribute on the methods with CFI checks disabled.

Types converted in this CL:
LayoutBlock, LayoutBlockFlow, InlineFlowBox, InlineBox.

While we have not observed CFI to slowdown real-world use cases,
there are a few blink_perf microbenchmarks, which are somewhat affected
by the change. This change removes CFI protection from the methods
which contribute the most to the slowdown.

Eventually, when proposed optimizations in Clang are implemented
(https://crbug.com/638056, https://crbug.com/638064), these attributes
would be possible to remove from all/most of the methods.

This CL does not in fact change the list of disabled methods, it
just converts them from CFI blacklist entries into attributes.
This should increase visibility, and also serve as a guard against refactoring.

BUG=641536
==========

[commit-bot: I haz the power, 2016-09-06 21:00:42]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-06 21:03:24]

Description was changed from

==========
Add DISABLE_CFI_PERF attribute on the methods with CFI checks disabled.

Types converted in this CL:
LayoutBlock, LayoutBlockFlow, InlineFlowBox, InlineBox.

While we have not observed CFI to slowdown real-world use cases,
there are a few blink_perf microbenchmarks, which are somewhat affected
by the change. This change removes CFI protection from the methods
which contribute the most to the slowdown.

Eventually, when proposed optimizations in Clang are implemented
(https://crbug.com/638056, https://crbug.com/638064), these attributes
would be possible to remove from all/most of the methods.

This CL does not in fact change the list of disabled methods, it
just converts them from CFI blacklist entries into attributes.
This should increase visibility, and also serve as a guard against refactoring.

BUG=641536
==========

to

==========
Add DISABLE_CFI_PERF attribute on the methods with CFI checks disabled.

Types converted in this CL:
LayoutBlock, LayoutBlockFlow, InlineFlowBox, InlineBox.

While we have not observed CFI to slowdown real-world use cases,
there are a few blink_perf microbenchmarks, which are somewhat affected
by the change. This change removes CFI protection from the methods
which contribute the most to the slowdown.

Eventually, when proposed optimizations in Clang are implemented
(https://crbug.com/638056, https://crbug.com/638064), these attributes
would be possible to remove from all/most of the methods.

This CL does not in fact change the list of disabled methods, it
just converts them from CFI blacklist entries into attributes.
This should increase visibility, and also serve as a guard against refactoring.

BUG=641536

Committed: https://crrev.com/5e2204ad64fdcbc8efc4d1cad26a9da5672a39a8
Cr-Commit-Position: refs/heads/master@{#416727}
==========

[commit-bot: I haz the power, 2016-09-06 21:03:25]

Patchset 4 (id:??) landed as
https://crrev.com/5e2204ad64fdcbc8efc4d1cad26a9da5672a39a8
Cr-Commit-Position: refs/heads/master@{#416727}