Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2304553002: Include only stuff you need, part 6: Fix cctest.h. (Closed)

Created:
4 years, 3 months ago by marja
Modified:
4 years, 3 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Include only stuff you need, part 6: Fix cctest.h. Rebuilding (after touching certain files) is crazy slow because includes are out of control. Many of these files we need to rebuild are cctests which pull in more includes than they need. BUG=v8:5294 Committed: https://crrev.com/8e7241fddee4c5bf5b6b73fe50915569dea96e9c Cr-Commit-Position: refs/heads/master@{#39080}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+345 lines, -82 lines) Patch
M test/cctest/cctest.h View 7 chunks +36 lines, -44 lines 0 comments Download
M test/cctest/cctest.cc View 2 chunks +62 lines, -0 lines 0 comments Download
M test/cctest/compiler/function-tester.h View 3 chunks +4 lines, -21 lines 0 comments Download
M test/cctest/compiler/function-tester.cc View 2 chunks +27 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-js-constant-cache.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-jsbranches.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-run-jscalls.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-jsexceptions.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-run-jsobjects.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-jsops.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-run-stackcheck.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-run-unwinding-info.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-variables.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/heap/test-array-buffer-tracker.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/heap/test-compaction.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M test/cctest/heap/test-lab.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/heap/test-page-promotion.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M test/cctest/heap/test-spaces.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/libsampler/test-sampler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-api.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-array-list.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M test/cctest/test-code-cache.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M test/cctest/test-code-layout.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M test/cctest/test-conversions.cc View 1 chunk +13 lines, -2 lines 0 comments Download
M test/cctest/test-date.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/test-decls.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-flags.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-global-handles.cc View 1 chunk +4 lines, -1 line 0 comments Download
M test/cctest/test-identity-map.cc View 1 chunk +11 lines, -3 lines 0 comments Download
M test/cctest/test-list.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/test-log.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/test-mementos.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M test/cctest/test-object.cc View 1 chunk +5 lines, -1 line 0 comments Download
M test/cctest/test-profile-generator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-random-number-generator.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/test-sampler-api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-simd.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M test/cctest/test-symbols.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M test/cctest/test-thread-termination.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/test-threads.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-transitions.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/test-types.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M test/cctest/test-unique.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M test/cctest/test-utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-weakmaps.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M test/cctest/test-weaksets.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M test/cctest/types-fuzz.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
marja
ptal
4 years, 3 months ago (2016-09-01 11:45:05 UTC) #4
titzer
On 2016/09/01 11:45:05, marja wrote: > ptal lgtm
4 years, 3 months ago (2016-09-01 11:51:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2304553002/1
4 years, 3 months ago (2016-09-01 11:54:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 12:01:39 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 12:02:22 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e7241fddee4c5bf5b6b73fe50915569dea96e9c
Cr-Commit-Position: refs/heads/master@{#39080}

Powered by Google App Engine
This is Rietveld 408576698