[css-grid] Fix definite height detection for auto-repet tracks

[css-grid] Fix definite height detection for auto-repet tracks

Previous code was considering that all positioned grid containers
with auto height have an indefinite height.
However if they have non-auto top and bottom properties,
the height is definite.

The patches uses LayoutBlock::hasDefiniteLogicalHeight() in
LayoutGrid::layoutBlock(). This is not fixing any bug,
but it's avoiding some unneeded calls, as we properly identify
the height as definite on the first step.

To fix the issue with auto-repeat tracks
LayoutGrid::computeAutoRepeatTracksCount() is modified in order to use
LayoutBlock::availableLogicalHeightForPercentageComputation().
That way the height of the grid container is properly calculated
and the number of repetitions is the right one.

Added a new test case to verify the expected behavior.

BUG=624301
TEST=fast/css-grid-layout/grid-auto-repeat-positioned-container.html

Committed: https://crrev.com/73bf22175e3b50c1c1c6d02d1858c9b60fee6b02
Cr-Commit-Position: refs/heads/master@{#416863}

[Manuel Rego, 2016-09-01 10:19:51]

rego@igalia.com changed reviewers:
+ cbiesinger@chromium.org, jfernandez@igalia.com, svillar@igalia.com

[Manuel Rego, 2016-09-01 10:19:52]

This should be fixing the issue detected in this comment:
https://bugs.chromium.org/p/chromium/issues/detail?id=624301#c8

[cbiesinger, 2016-09-02 19:14:20]

lgtm

[Manuel Rego, 2016-09-07 05:03:05]

The CQ bit was checked by rego@igalia.com

[commit-bot: I haz the power, 2016-09-07 05:03:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 06:28:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-07 06:29:43]

Description was changed from

==========
[css-grid] Fix definite height detection for auto-repet tracks

Previous code was considering that all positioned grid containers
with auto height have an indefinite height.
However if they have non-auto top and bottom properties,
the height is definite.

The patches uses LayoutBlock::hasDefiniteLogicalHeight() in
LayoutGrid::layoutBlock(). This is not fixing any bug,
but it's avoiding some unneeded calls, as we properly identify
the height as definite on the first step.

To fix the issue with auto-repeat tracks
LayoutGrid::computeAutoRepeatTracksCount() is modified in order to use
LayoutBlock::availableLogicalHeightForPercentageComputation().
That way the height of the grid container is properly calculated
and the number of repetitions is the right one.

Added a new test case to verify the expected behavior.

BUG=624301
TEST=fast/css-grid-layout/grid-auto-repeat-positioned-container.html
==========

to

==========
[css-grid] Fix definite height detection for auto-repet tracks

Previous code was considering that all positioned grid containers
with auto height have an indefinite height.
However if they have non-auto top and bottom properties,
the height is definite.

The patches uses LayoutBlock::hasDefiniteLogicalHeight() in
LayoutGrid::layoutBlock(). This is not fixing any bug,
but it's avoiding some unneeded calls, as we properly identify
the height as definite on the first step.

To fix the issue with auto-repeat tracks
LayoutGrid::computeAutoRepeatTracksCount() is modified in order to use
LayoutBlock::availableLogicalHeightForPercentageComputation().
That way the height of the grid container is properly calculated
and the number of repetitions is the right one.

Added a new test case to verify the expected behavior.

BUG=624301
TEST=fast/css-grid-layout/grid-auto-repeat-positioned-container.html

Committed: https://crrev.com/73bf22175e3b50c1c1c6d02d1858c9b60fee6b02
Cr-Commit-Position: refs/heads/master@{#416863}
==========

[commit-bot: I haz the power, 2016-09-07 06:29:44]

Patchset 1 (id:??) landed as
https://crrev.com/73bf22175e3b50c1c1c6d02d1858c9b60fee6b02
Cr-Commit-Position: refs/heads/master@{#416863}