Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2304533002: [gn] Switch arm simulators to gn (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
jbramley, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Switch arm simulators to gn BUG=chromium:474921 Committed: https://crrev.com/bbe5c5490c4869c31984f335fa8ae0fee1d48c4a Cr-Commit-Position: refs/heads/master@{#39081}

Patch Set 1 #

Patch Set 2 : [gn] Switch arm simulators to gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M infra/mb/mb_config.pyl View 1 6 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Michael Achenbach
PTAL Expected differences: We now have CAN_USE_VFP32DREGS off. This only impacts snapshot creation and there ...
4 years, 3 months ago (2016-09-01 10:03:42 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-01 12:06:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2304533002/20001
4 years, 3 months ago (2016-09-01 12:16:14 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-01 12:18:32 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 12:19:05 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bbe5c5490c4869c31984f335fa8ae0fee1d48c4a
Cr-Commit-Position: refs/heads/master@{#39081}

Powered by Google App Engine
This is Rietveld 408576698