Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 3 months ago by Michael Achenbach Modified:
4 years, 3 months ago Reviewers:
jochen (gone - plz use gerrit), vogelheim CC:
jbramley, v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[gn] Switch arm simulators to gn
BUG=chromium:474921
Committed: https://crrev.com/bbe5c5490c4869c31984f335fa8ae0fee1d48c4a
Cr-Commit-Position: refs/heads/master@{#39081}
Patch Set 1 #Patch Set 2 : [gn] Switch arm simulators to gn #
Created: 4 years, 3 months ago
Messages
Total messages: 14 (9 generated)
Description was changed from ========== [gn] Switch arm simulators to gn BUG= ========== to ========== [gn] Switch arm simulators to gn BUG=chromium:474921 ==========
machenbach@chromium.org changed reviewers: + jochen@chromium.org, vogelheim@chromium.org
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL Expected differences: We now have CAN_USE_VFP32DREGS off. This only impacts snapshot creation and there it's better to use the smallest snapshot possible. Furthermore, it's the same way chrome creates our snapshots ATM. _GLIBCXX_DEBUG=1 is off now in debug just like on linux32 platform (already discussed there). Comparison links: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm%20... https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm%20... https://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [gn] Switch arm simulators to gn BUG=chromium:474921 ========== to ========== [gn] Switch arm simulators to gn BUG=chromium:474921 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [gn] Switch arm simulators to gn BUG=chromium:474921 ========== to ========== [gn] Switch arm simulators to gn BUG=chromium:474921 Committed: https://crrev.com/bbe5c5490c4869c31984f335fa8ae0fee1d48c4a Cr-Commit-Position: refs/heads/master@{#39081} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/bbe5c5490c4869c31984f335fa8ae0fee1d48c4a Cr-Commit-Position: refs/heads/master@{#39081} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
