Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1482)

Unified Diff: chrome/browser/infobars/infobar_delegate.cc

Issue 230453004: Remove InfoBarDelegate::web_contents() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix compile Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/infobars/infobar_delegate.cc
diff --git a/chrome/browser/infobars/infobar_delegate.cc b/chrome/browser/infobars/infobar_delegate.cc
index db645f2524814effb83aa45db411720550ed346b..e733f4390fe779305de4036c3fc476749db72aed 100644
--- a/chrome/browser/infobars/infobar_delegate.cc
+++ b/chrome/browser/infobars/infobar_delegate.cc
@@ -95,9 +95,13 @@ TranslateInfoBarDelegate* InfoBarDelegate::AsTranslateInfoBarDelegate() {
}
void InfoBarDelegate::StoreActiveEntryUniqueID() {
- DCHECK(web_contents());
+ // TODO(droger): Remove this dependency on InfoBarService, see
+ // http://crbug.com/354379.
+ content::WebContents* web_contents =
+ InfoBarService::WebContentsFromInfoBar(infobar());
+ DCHECK(web_contents);
NavigationEntry* active_entry =
- web_contents()->GetController().GetActiveEntry();
+ web_contents->GetController().GetActiveEntry();
contents_unique_id_ = active_entry ? active_entry->GetUniqueID() : 0;
}
@@ -107,10 +111,6 @@ gfx::Image InfoBarDelegate::GetIcon() const {
ResourceBundle::GetSharedInstance().GetNativeImageNamed(icon_id);
}
-content::WebContents* InfoBarDelegate::web_contents() {
- return InfoBarService::WebContentsFromInfoBar(infobar_);
-}
-
InfoBarDelegate::InfoBarDelegate() : contents_unique_id_(0) {
}
« no previous file with comments | « chrome/browser/infobars/infobar_delegate.h ('k') | chrome/browser/infobars/insecure_content_infobar_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698