Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 230453004: Remove InfoBarDelegate::web_contents() (Closed)

Created:
6 years, 8 months ago by droger
Modified:
6 years, 8 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, jam, stuartmorgan+watch_chromium.org, feature-media-reviews_chromium.org, benquan, wjia+watch_chromium.org, Michael van Ouwerkerk, browser-components-watch_chromium.org, mcasas+watch_chromium.org, fischman+watch_chromium.org, pam+watch_chromium.org, Dane Wallinga, dyu1, chromium-apps-reviews_chromium.org, estade+watch_chromium.org, markusheintz_, native-client-reviews_googlegroups.com, Ilya Sherman, rouslan+autofillwatch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Remove InfoBarDelegate::web_contents() In order to move InfoBarDelegate to the infobar components, all dependencies on content/ must be removed. This CL removes the InfoBarDelegate::web_contents() method and callers use InfoBarService::WebContentsFromInfobar() instead. BUG=354379 TBR=jochen Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263044

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fix typo #

Patch Set 3 : fix android #

Total comments: 1

Patch Set 4 : format #

Patch Set 5 : fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -132 lines) Patch
M chrome/browser/autofill/autofill_cc_infobar_delegate.cc View 1 2 3 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/custom_handlers/register_protocol_handler_infobar_delegate.cc View 1 2 3 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_infobar_delegate.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_infobar_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/geolocation/geolocation_infobar_delegate.cc View 1 2 3 2 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/google/google_url_tracker_infobar_delegate.cc View 1 2 3 2 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/infobars/infobar_delegate.h View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/infobars/infobar_delegate.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/infobars/insecure_content_infobar_delegate.cc View 1 2 3 2 chunks +13 lines, -9 lines 0 comments Download
M chrome/browser/managed_mode/managed_mode_navigation_observer.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/media/media_stream_infobar_delegate.cc View 1 2 3 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/media/midi_permission_infobar_delegate.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/media/protected_media_identifier_infobar_delegate.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_infobar_delegate.cc View 1 2 3 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/pepper_broker_infobar_delegate.cc View 1 2 3 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/plugins/plugin_infobar_delegates.cc View 1 2 3 5 chunks +26 lines, -19 lines 0 comments Download
M chrome/browser/ssl/ssl_tab_helper.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/three_d_api_observer.cc View 1 2 3 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/translate/options_menu_model.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/translate/translate_infobar_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/translate/translate_infobar_delegate.cc View 1 2 3 4 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/ui/android/content_settings/popup_blocked_infobar_delegate.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/android/infobars/auto_login_infobar_delegate_android.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/auto_login_infobar_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/auto_login_infobar_delegate.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/extension_infobar_controller.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/collected_cookies_infobar_delegate.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/content_settings/media_setting_changed_infobar_delegate.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/extensions/extension_install_ui_default.cc View 1 2 3 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.cc View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/startup/google_api_keys_infobar_delegate.cc View 1 2 3 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/startup/obsolete_system_infobar_delegate.cc View 1 2 3 1 chunk +8 lines, -6 lines 0 comments Download
M chrome/browser/ui/startup/session_crashed_infobar_delegate.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/website_settings/website_settings_infobar_delegate.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
droger
This CL depends on https://codereview.chromium.org/228293004
6 years, 8 months ago (2014-04-09 12:24:12 UTC) #1
blundell
Looks good https://codereview.chromium.org/230453004/diff/1/chrome/browser/extensions/extension_infobar_delegate.h File chrome/browser/extensions/extension_infobar_delegate.h (right): https://codereview.chromium.org/230453004/diff/1/chrome/browser/extensions/extension_infobar_delegate.h#newcode48 chrome/browser/extensions/extension_infobar_delegate.h:48: // Returns the WebContents associates with the ...
6 years, 8 months ago (2014-04-09 12:35:11 UTC) #2
droger
https://codereview.chromium.org/230453004/diff/1/chrome/browser/infobars/infobar_delegate.cc File chrome/browser/infobars/infobar_delegate.cc (right): https://codereview.chromium.org/230453004/diff/1/chrome/browser/infobars/infobar_delegate.cc#newcode101 chrome/browser/infobars/infobar_delegate.cc:101: InfoBarService::WebContentsFromInfoBar(infobar()); On 2014/04/09 12:35:12, blundell wrote: > How much ...
6 years, 8 months ago (2014-04-09 12:44:05 UTC) #3
droger
https://codereview.chromium.org/230453004/diff/1/chrome/browser/infobars/infobar_delegate.cc File chrome/browser/infobars/infobar_delegate.cc (right): https://codereview.chromium.org/230453004/diff/1/chrome/browser/infobars/infobar_delegate.cc#newcode101 chrome/browser/infobars/infobar_delegate.cc:101: InfoBarService::WebContentsFromInfoBar(infobar()); On 2014/04/09 12:35:12, blundell wrote: > How much ...
6 years, 8 months ago (2014-04-09 13:22:53 UTC) #4
blundell
LGTM
6 years, 8 months ago (2014-04-09 15:19:35 UTC) #5
droger
+pkasting
6 years, 8 months ago (2014-04-09 16:08:10 UTC) #6
Peter Kasting
LGTM https://codereview.chromium.org/230453004/diff/50001/chrome/browser/autofill/autofill_cc_infobar_delegate.cc File chrome/browser/autofill/autofill_cc_infobar_delegate.cc (right): https://codereview.chromium.org/230453004/diff/50001/chrome/browser/autofill/autofill_cc_infobar_delegate.cc#newcode108 chrome/browser/autofill/autofill_cc_infobar_delegate.cc:108: content::PAGE_TRANSITION_LINK, false)); Nit: This type of wrapping would ...
6 years, 8 months ago (2014-04-10 00:13:50 UTC) #7
droger
TBR=jochen as OWNER of everything except infobars/, ui/ and translate/
6 years, 8 months ago (2014-04-10 15:33:33 UTC) #8
droger
The CQ bit was checked by droger@chromium.org
6 years, 8 months ago (2014-04-10 17:59:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/droger@chromium.org/230453004/100001
6 years, 8 months ago (2014-04-10 17:59:32 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 19:11:18 UTC) #11
Message was sent while issue was closed. 
Change committed as 263044

Powered by Google App Engine
This is Rietveld 408576698