Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issue 230453002: Fix return value of push() and unshift() on Array.prototype. (Closed)

Created:
6 years, 8 months ago by Michael Starzinger
Modified:
6 years, 8 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Fix return value of push() and unshift() on Array.prototype. R=ulan@chromium.org TEST=mjsunit/regress/regress-builtinbust-3 Committed: https://code.google.com/p/v8/source/detail?r=20602

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -9 lines) Patch
M src/array.js View 4 chunks +13 lines, -9 lines 0 comments Download
A test/mjsunit/regress/regress-builtinbust-3.js View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
6 years, 8 months ago (2014-04-09 08:45:29 UTC) #1
ulan
lgtm, good catch!
6 years, 8 months ago (2014-04-09 09:03:16 UTC) #2
Michael Starzinger
6 years, 8 months ago (2014-04-09 09:15:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20602 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698