sdk/lib/_internal/lib/js_mirrors.dart - Issue 23045004: Throw when reflecting on elements not covered by a `MirrorsUsed` annotation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/lib/js_mirrors.dart

Issue 23045004: Throw when reflecting on elements not covered by a `MirrorsUsed` annotation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('K') | « sdk/lib/_internal/compiler/implementation/mirrors_used.dart ('k') | tests/compiler/dart2js_extra/mirror_invalid_field_access2_test.dart » ('j') | tests/compiler/dart2js_extra/mirror_invalid_field_access2_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/lib/js_mirrors.dart

diff --git a/sdk/lib/_internal/lib/js_mirrors.dart b/sdk/lib/_internal/lib/js_mirrors.dart

index 52aca10326e72eb235fd37debd112a095ab4aadf..6b050cfee8129cea5014f3ce2133f41ffdb126d7 100644

--- a/sdk/lib/_internal/lib/js_mirrors.dart

+++ b/sdk/lib/_internal/lib/js_mirrors.dart

@@ -260,7 +260,7 @@ class JsLibraryMirror extends JsDeclarationMirror with JsObjectMirror

InstanceMirror invoke(Symbol memberName,

List positionalArguments,

- [Map<Symbol,dynamic> namedArguments]) {

+ [Map<Symbol, dynamic> namedArguments]) {

if (namedArguments != null && !namedArguments.isEmpty) {

throw new UnsupportedError('Named arguments are not implemented.');

}