sdk/lib/_internal/compiler/implementation/js_backend/namer.dart - Issue 23045004: Throw when reflecting on elements not covered by a `MirrorsUsed` annotation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

Issue 23045004: Throw when reflecting on elements not covered by a `MirrorsUsed` annotation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address Nicolas' comments. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('k') | sdk/lib/_internal/compiler/implementation/mirrors_used.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart b/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

index e1246bf341ad488b8eca9f14fb80903ee1d0ace9..cfb179c210fe11e521f68c04a04e529586212e61 100644

--- a/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

@@ -182,6 +182,7 @@ class Namer implements ClosureNamer {

final String setterPrefix = r'set$';

final String metadataField = '@';

final String callCatchAllName = r'call$catchAll';

+ final String reflectableField = r'$reflectable';

/**

* Map from top-level or static elements to their unique identifiers provided

@@ -243,6 +244,7 @@ class Namer implements ClosureNamer {

case 'GETTER_PREFIX': return getterPrefix;

case 'SETTER_PREFIX': return setterPrefix;

case 'CALL_CATCH_ALL': return callCatchAllName;

+ case 'REFLECTABLE': return reflectableField;

default:

compiler.reportError(

node, MessageKind.GENERIC,