Move CFX_Font definition to its own file

Move CFX_Font definition to its own file and clean up

- Rename fx_ge_font.cpp to cfx_font.cpp
- Deleted unused CONTRAST_RAMP_STEP in fx_ge_text.cpp
- Move CFX_Font definitions and auxiliary methods in fx_ge_text to cfx_font
- Remove extern "C", static, and underscore prefixes in new namespace
methods in cfx_font.cpp

Committed: https://pdfium.googlesource.com/pdfium/+/155c88006a4367bb09631c3ca4983ef48e06bc62

[npm, 2016-09-02 15:27:00]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 15:27:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2016-09-02 15:33:14]

Description was changed from

==========
Move CFX_Font definition to its own file
==========

to

==========
Move CFX_Font definition to its own file and clean up

- Rename fx_ge_font.cpp to cfx_font.cpp
- Deleted unused CONTRAST_RAMP_STEP in fx_ge_text.cpp
- Move CFX_Font definitions and auxiliary methods in fx_ge_text to cfx_font
- Remove extern "C", static, and underscore prefixes in new namespace
methods in cfx_font.cpp
==========

[npm, 2016-09-02 15:33:14]

npm@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org, weili@chromium.org

[npm, 2016-09-02 15:34:13]

PTAL

[commit-bot: I haz the power, 2016-09-02 15:39:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 15:39:18]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-09-06 12:57:03]

https://codereview.chromium.org/2304493005/diff/1/core/fxge/ge/cfx_font.cpp
File core/fxge/ge/cfx_font.cpp (right):

https://codereview.chromium.org/2304493005/diff/1/core/fxge/ge/cfx_font.cpp#n...
core/fxge/ge/cfx_font.cpp:188: const char CFX_Font::s_AngleSkew[] = {
Are these referenced externally? If not, can they move into the anonymous
namespace?

[npm, 2016-09-06 14:21:53]

https://codereview.chromium.org/2304493005/diff/1/core/fxge/ge/cfx_font.cpp
File core/fxge/ge/cfx_font.cpp (right):

https://codereview.chromium.org/2304493005/diff/1/core/fxge/ge/cfx_font.cpp#n...
core/fxge/ge/cfx_font.cpp:188: const char CFX_Font::s_AngleSkew[] = {
On 2016/09/06 12:57:03, dsinclair wrote:
> Are these referenced externally? If not, can they move into the anonymous
> namespace?

They are referenced by CFX_FaceCache

[dsinclair, 2016-09-06 14:22:33]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-09-06 14:22:34]

lgtm

[commit-bot: I haz the power, 2016-09-06 14:22:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 14:31:04]

Description was changed from

==========
Move CFX_Font definition to its own file and clean up

- Rename fx_ge_font.cpp to cfx_font.cpp
- Deleted unused CONTRAST_RAMP_STEP in fx_ge_text.cpp
- Move CFX_Font definitions and auxiliary methods in fx_ge_text to cfx_font
- Remove extern "C", static, and underscore prefixes in new namespace
methods in cfx_font.cpp
==========

to

==========
Move CFX_Font definition to its own file and clean up

- Rename fx_ge_font.cpp to cfx_font.cpp
- Deleted unused CONTRAST_RAMP_STEP in fx_ge_text.cpp
- Move CFX_Font definitions and auxiliary methods in fx_ge_text to cfx_font
- Remove extern "C", static, and underscore prefixes in new namespace
methods in cfx_font.cpp

Committed:
https://pdfium.googlesource.com/pdfium/+/155c88006a4367bb09631c3ca4983ef48e06...
==========

[commit-bot: I haz the power, 2016-09-06 14:31:05]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/155c88006a4367bb09631c3ca4983ef48e06...