Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: runtime/observatory/lib/src/app/application.dart

Issue 2304463002: Converted Observatory vm-view && isolate-view elements (Closed)
Patch Set: Fixed typo Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/service.dart ('k') | runtime/observatory/lib/src/app/event.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/app/application.dart
diff --git a/runtime/observatory/lib/src/app/application.dart b/runtime/observatory/lib/src/app/application.dart
index 3ab1142e73114a9491b5799a5a7c827d4812b878..1d13c9f19c26a616c56f81a99f9d985db7e5aa84 100644
--- a/runtime/observatory/lib/src/app/application.dart
+++ b/runtime/observatory/lib/src/app/application.dart
@@ -96,77 +96,10 @@ class ObservatoryApplication extends Observable {
void _onEvent(ServiceEvent event) {
assert(event.kind != ServiceEvent.kNone);
- M.Event e;
-
- switch(event.kind) {
- case ServiceEvent.kVMUpdate:
- e = new VMUpdateEvent(event.timestamp, event.vm);
- break;
- case ServiceEvent.kIsolateStart:
- e = new IsolateStartEvent(event.timestamp, event.isolate);
- break;
- case ServiceEvent.kIsolateRunnable:
- e = new IsolateRunnableEvent(event.timestamp, event.isolate);
- break;
- case ServiceEvent.kIsolateUpdate:
- e = new IsolateUpdateEvent(event.timestamp, event.isolate);
- break;
- case ServiceEvent.kIsolateReload:
- e = new IsolateReloadEvent(event.timestamp, event.isolate, event.error);
- break;
- case ServiceEvent.kIsolateExit:
- e = new IsolateExitEvent(event.timestamp, event.isolate);
- break;
- case ServiceEvent.kBreakpointAdded:
- e = new BreakpointAddedEvent(event.timestamp, event.isolate,
- event.breakpoint);
- break;
- case ServiceEvent.kBreakpointResolved:
- e = new BreakpointResolvedEvent(event.timestamp, event.isolate,
- event.breakpoint);
- break;
- case ServiceEvent.kBreakpointRemoved:
- e = new BreakpointRemovedEvent(event.timestamp, event.isolate,
- event.breakpoint);
- break;
- case ServiceEvent.kDebuggerSettingsUpdate:
- e = new DebuggerSettingsUpdateEvent(event.timestamp, event.isolate);
- break;
- case ServiceEvent.kResume:
- e = new ResumeEvent(event.timestamp, event.isolate, event.topFrame);
- break;
- case ServiceEvent.kPauseStart:
- e = new PauseStartEvent(event.timestamp, event.isolate);
- break;
- case ServiceEvent.kPauseExit:
- e = new PauseExitEvent(event.timestamp, event.isolate);
- break;
- case ServiceEvent.kPauseBreakpoint:
- e = new PauseBreakpointEvent(event.timestamp, event.isolate,
- event.pauseBreakpoints, event.topFrame, event.atAsyncSuspension,
- event.breakpoint);
- break;
- case ServiceEvent.kPauseInterrupted:
- e = new PauseInterruptedEvent(event.timestamp, event.isolate,
- event.topFrame, event.atAsyncSuspension);
- break;
- case ServiceEvent.kPauseException:
- e = new PauseExceptionEvent(event.timestamp, event.isolate,
- event.topFrame, event.exception);
- break;
- case ServiceEvent.kInspect:
- e = new InspectEvent(event.timestamp, event.isolate,
- event.inspectee);
- break;
- case ServiceEvent.kGC:
- e = new GCEvent(event.timestamp, event.isolate);
- break;
- default:
- // Ignore unrecognized events.
- Logger.root.severe('Unrecognized event: $event');
- return;
+ M.Event e = createEventFromServiceEvent(event);
+ if (e != null) {
+ events.add(e);
}
- events.add(e);
}
void _registerPages() {
« no previous file with comments | « runtime/observatory/lib/service.dart ('k') | runtime/observatory/lib/src/app/event.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698