Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2304463002: Converted Observatory vm-view && isolate-view elements (Closed)

Created:
4 years, 3 months ago by cbernaschina
Modified:
4 years, 3 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Converted Observatory vm-view && isolate-view elements R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/90c50c52f2c178169452447adfca73605aa3d2d5

Patch Set 1 #

Patch Set 2 : Fixed menu #

Patch Set 3 : Removed trailing whitespaces #

Total comments: 2

Patch Set 4 : Fixed typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1090 lines, -969 lines) Patch
M runtime/observatory/lib/app.dart View 2 chunks +1 line, -1 line 0 comments Download
M runtime/observatory/lib/elements.dart View 1 2 8 chunks +15 lines, -5 lines 0 comments Download
M runtime/observatory/lib/elements.html View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
A + runtime/observatory/lib/event.dart View 2 chunks +58 lines, -1 line 0 comments Download
M runtime/observatory/lib/models.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/repositories.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/service.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/application.dart View 1 chunk +3 lines, -70 lines 0 comments Download
D runtime/observatory/lib/src/app/event.dart View 1 chunk +0 lines, -254 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 1 2 4 chunks +32 lines, -8 lines 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 1 2 3 chunks +25 lines, -8 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.dart View 11 chunks +30 lines, -25 lines 0 comments Download
M runtime/observatory/lib/src/elements/helpers/uris.dart View 1 chunk +3 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/isolate/location.dart View 1 chunk +125 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/isolate/run_state.dart View 1 chunk +82 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate/shared_summary.dart View 5 chunks +15 lines, -1 line 0 comments Download
D runtime/observatory/lib/src/elements/isolate/shared_summary_wrapper.dart View 1 chunk +0 lines, -169 lines 0 comments Download
A runtime/observatory/lib/src/elements/isolate/summary.dart View 1 chunk +106 lines, -0 lines 0 comments Download
D runtime/observatory/lib/src/elements/isolate_summary.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D runtime/observatory/lib/src/elements/isolate_summary.html View 1 chunk +0 lines, -87 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_view.dart View 1 1 chunk +282 lines, -23 lines 0 comments Download
D runtime/observatory/lib/src/elements/isolate_view.html View 1 chunk +0 lines, -140 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_inset_wrapper.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_view.dart View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_view.html View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/source_inset_wrapper.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_view.dart View 1 chunk +179 lines, -9 lines 0 comments Download
D runtime/observatory/lib/src/elements/vm_view.html View 1 chunk +0 lines, -78 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/event.dart View 1 2 3 1 chunk +26 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/frame.dart View 1 chunk +4 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/models/objects/isolate.dart View 1 2 3 chunks +15 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/vm.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A + runtime/observatory/lib/src/models/repositories/isolate.dart View 1 chunk +3 lines, -2 lines 0 comments Download
A + runtime/observatory/lib/src/repositories/isolate.dart View 1 chunk +7 lines, -5 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 6 chunks +17 lines, -11 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/isolate/isolate-shared-summary/element_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/isolate.dart View 1 chunk +7 lines, -2 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/vm.dart View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/get_object_store_rpc_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/get_stack_rpc_test.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/pause_idle_isolate_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/pause_on_start_and_exit_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/pause_on_start_then_step_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/service_test_common.dart View 1 2 3 chunks +16 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/smart_next_test.dart View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/step_over_await_test.dart View 1 2 3 3 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
cbernaschina
4 years, 3 months ago (2016-08-31 23:08:35 UTC) #2
cbernaschina
4 years, 3 months ago (2016-08-31 23:36:11 UTC) #3
rmacnak
lgtm https://chromiumcodereview.appspot.com/2304463002/diff/40001/runtime/observatory/lib/src/models/objects/event.dart File runtime/observatory/lib/src/models/objects/event.dart (right): https://chromiumcodereview.appspot.com/2304463002/diff/40001/runtime/observatory/lib/src/models/objects/event.dart#newcode163 runtime/observatory/lib/src/models/objects/event.dart:163: bool isAtAsyncSuspection(DebugEvent event) { isAtAsyncSuspension
4 years, 3 months ago (2016-09-01 17:41:28 UTC) #4
cbernaschina
https://codereview.chromium.org/2304463002/diff/40001/runtime/observatory/lib/src/models/objects/event.dart File runtime/observatory/lib/src/models/objects/event.dart (right): https://codereview.chromium.org/2304463002/diff/40001/runtime/observatory/lib/src/models/objects/event.dart#newcode163 runtime/observatory/lib/src/models/objects/event.dart:163: bool isAtAsyncSuspection(DebugEvent event) { On 2016/09/01 17:41:28, rmacnak wrote: ...
4 years, 3 months ago (2016-09-01 17:43:59 UTC) #5
cbernaschina
4 years, 3 months ago (2016-09-01 17:46:45 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
90c50c52f2c178169452447adfca73605aa3d2d5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698