Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8620)

Unified Diff: chrome/test/chromedriver/chrome/devtools_http_client.cc

Issue 2304433002: [chromedriver] Do not identify extension background pages by url scheme. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/devtools_http_client.cc
diff --git a/chrome/test/chromedriver/chrome/devtools_http_client.cc b/chrome/test/chromedriver/chrome/devtools_http_client.cc
index ea1f1ddd76767ebf83bf865495d532be383f2c76..6409e8b8b2e1b1c2afebaf00a9861e9fa095e0cf 100644
--- a/chrome/test/chromedriver/chrome/devtools_http_client.cc
+++ b/chrome/test/chromedriver/chrome/devtools_http_client.cc
@@ -160,9 +160,7 @@ const DeviceMetrics* DevToolsHttpClient::device_metrics() {
bool DevToolsHttpClient::IsBrowserWindow(const WebViewInfo& view) const {
return base::ContainsKey(*window_types_, view.type) ||
(view.type == WebViewInfo::kOther &&
- (base::StartsWith(view.url, "chrome-extension://",
- base::CompareCase::SENSITIVE) ||
- view.url == "chrome://print/" ||
+ (view.url == "chrome://print/" ||
view.url == "chrome://media-router/"));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698