Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2304433002: [chromedriver] Do not identify extension background pages by url scheme. (Closed)

Created:
4 years, 3 months ago by samuong
Modified:
4 years, 3 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, samuong+watch_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Do not identify extension background pages by url scheme. BUG=642902 Committed: https://crrev.com/329ded4ea587e22b0d2660bafdd3e8d98300a972 Cr-Commit-Position: refs/heads/master@{#415873}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/test/chromedriver/chrome/devtools_http_client.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
samuong
Pavel, could you please take a look? There's some more context in the bug, but ...
4 years, 3 months ago (2016-08-31 22:06:12 UTC) #3
pfeldman
lgtm
4 years, 3 months ago (2016-09-01 02:03:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2304433002/1
4 years, 3 months ago (2016-09-01 02:58:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 03:39:02 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 03:40:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/329ded4ea587e22b0d2660bafdd3e8d98300a972
Cr-Commit-Position: refs/heads/master@{#415873}

Powered by Google App Engine
This is Rietveld 408576698