Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 230443005: Move cronet from //net into //components. (Closed)

Created:
6 years, 8 months ago by mef
Modified:
6 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Move cronet from //net into //components. BUG=354143 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262875

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address blundell's comments. #

Patch Set 3 : Sync to r262794 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -4113 lines) Patch
M components/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M components/components.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A components/cronet.gypi View 1 1 chunk +191 lines, -0 lines 0 comments Download
A + components/cronet/DEPS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A components/cronet/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A + components/cronet/android/DEPS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/java/src/org/chromium/net/ChunkedWritableByteChannel.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/java/src/org/chromium/net/HttpUrlRequest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactory.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/java/src/org/chromium/net/HttpUrlRequestListener.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/java/src/org/chromium/net/ResponseTooLargeException.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/java/src/org/chromium/net/UrlRequest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/java/src/org/chromium/net/UrlRequestError.template View 1 chunk +1 line, -1 line 0 comments Download
A + components/cronet/android/java/src/org/chromium/net/UrlRequestPriority.template View 1 chunk +1 line, -1 line 0 comments Download
A + components/cronet/android/java/src/org/chromium/net/UsedByReflection.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/java/src/org/chromium/net/UserAgent.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/org_chromium_net_UrlRequest.h View 4 chunks +5 lines, -5 lines 0 comments Download
A + components/cronet/android/org_chromium_net_UrlRequest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/cronet/android/org_chromium_net_UrlRequestContext.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/cronet/android/org_chromium_net_UrlRequest_error_list.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/org_chromium_net_UrlRequest_priority_list.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/sample/AndroidManifest.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/sample/javatests/AndroidManifest.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/ChunkedWritableByteChannelTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/Criteria.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CriteriaHelper.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSamplePreconditionsTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleTestBase.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/sample/res/layout/cronet_sample_activity.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/sample/res/values/strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleApplication.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/sample/src/org/chromium/cronet_sample_apk/LibraryLoader.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cronet/android/url_request_context_peer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/cronet/android/url_request_context_peer.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/cronet/android/url_request_peer.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/cronet/android/url_request_peer.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D net/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java View 1 chunk +0 lines, -188 lines 0 comments Download
D net/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java View 1 chunk +0 lines, -45 lines 0 comments Download
D net/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java View 1 chunk +0 lines, -52 lines 0 comments Download
D net/cronet/android/java/src/org/chromium/net/ChunkedWritableByteChannel.java View 1 chunk +0 lines, -123 lines 0 comments Download
D net/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequest.java View 1 chunk +0 lines, -433 lines 0 comments Download
D net/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java View 1 chunk +0 lines, -47 lines 0 comments Download
D net/cronet/android/java/src/org/chromium/net/HttpUrlRequest.java View 1 chunk +0 lines, -120 lines 0 comments Download
D net/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactory.java View 1 chunk +0 lines, -105 lines 0 comments Download
D net/cronet/android/java/src/org/chromium/net/HttpUrlRequestListener.java View 1 chunk +0 lines, -17 lines 0 comments Download
D net/cronet/android/java/src/org/chromium/net/ResponseTooLargeException.java View 1 chunk +0 lines, -17 lines 0 comments Download
D net/cronet/android/java/src/org/chromium/net/UrlRequest.java View 1 chunk +0 lines, -427 lines 0 comments Download
D net/cronet/android/java/src/org/chromium/net/UrlRequestContext.java View 1 chunk +0 lines, -121 lines 0 comments Download
D net/cronet/android/java/src/org/chromium/net/UrlRequestError.template View 1 chunk +0 lines, -14 lines 0 comments Download
D net/cronet/android/java/src/org/chromium/net/UrlRequestPriority.template View 1 chunk +0 lines, -14 lines 0 comments Download
D net/cronet/android/java/src/org/chromium/net/UsedByReflection.java View 1 chunk +0 lines, -24 lines 0 comments Download
D net/cronet/android/java/src/org/chromium/net/UserAgent.java View 1 chunk +0 lines, -74 lines 0 comments Download
D net/cronet/android/org_chromium_net_UrlRequest.h View 1 chunk +0 lines, -32 lines 0 comments Download
D net/cronet/android/org_chromium_net_UrlRequest.cc View 1 chunk +0 lines, -301 lines 0 comments Download
D net/cronet/android/org_chromium_net_UrlRequestContext.cc View 1 chunk +0 lines, -168 lines 0 comments Download
D net/cronet/android/org_chromium_net_UrlRequest_error_list.h View 1 chunk +0 lines, -14 lines 0 comments Download
D net/cronet/android/org_chromium_net_UrlRequest_priority_list.h View 1 chunk +0 lines, -14 lines 0 comments Download
D net/cronet/android/sample/AndroidManifest.xml View 1 chunk +0 lines, -29 lines 0 comments Download
D net/cronet/android/sample/javatests/AndroidManifest.xml View 1 chunk +0 lines, -23 lines 0 comments Download
D net/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/ChunkedWritableByteChannelTest.java View 1 chunk +0 lines, -82 lines 0 comments Download
D net/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/Criteria.java View 1 chunk +0 lines, -17 lines 0 comments Download
D net/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CriteriaHelper.java View 1 chunk +0 lines, -86 lines 0 comments Download
D net/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSamplePreconditionsTest.java View 1 chunk +0 lines, -26 lines 0 comments Download
D net/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleTestBase.java View 1 chunk +0 lines, -150 lines 0 comments Download
D net/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java View 1 chunk +0 lines, -89 lines 0 comments Download
D net/cronet/android/sample/res/layout/cronet_sample_activity.xml View 1 chunk +0 lines, -13 lines 0 comments Download
D net/cronet/android/sample/res/values/strings.xml View 1 chunk +0 lines, -10 lines 0 comments Download
D net/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java View 1 chunk +0 lines, -225 lines 0 comments Download
D net/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleApplication.java View 1 chunk +0 lines, -31 lines 0 comments Download
D net/cronet/android/sample/src/org/chromium/cronet_sample_apk/LibraryLoader.java View 1 chunk +0 lines, -24 lines 0 comments Download
D net/cronet/android/url_request_context_peer.h View 1 chunk +0 lines, -92 lines 0 comments Download
D net/cronet/android/url_request_context_peer.cc View 1 chunk +0 lines, -261 lines 0 comments Download
D net/cronet/android/url_request_peer.h View 1 chunk +0 lines, -137 lines 0 comments Download
D net/cronet/android/url_request_peer.cc View 1 chunk +0 lines, -296 lines 0 comments Download
M net/net.gyp View 1 2 1 chunk +0 lines, -183 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mef
Hi guys, please take a look. This is straight move of cronet from //net into ...
6 years, 8 months ago (2014-04-09 16:50:53 UTC) #1
mmenke
On 2014/04/09 16:50:53, mef wrote: > Hi guys, please take a look. > This is ...
6 years, 8 months ago (2014-04-09 19:02:48 UTC) #2
blundell
Wow, Java is verbose :). The native code of the component should be in the ...
6 years, 8 months ago (2014-04-09 20:04:12 UTC) #3
mef
Thanks! I'll change namespace from net:: to cronet:: in a separate CL. https://codereview.chromium.org/230443005/diff/1/components/OWNERS File components/OWNERS ...
6 years, 8 months ago (2014-04-09 20:19:38 UTC) #4
mef
The CQ bit was checked by mef@chromium.org
6 years, 8 months ago (2014-04-09 22:05:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mef@chromium.org/230443005/40001
6 years, 8 months ago (2014-04-09 22:05:51 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 00:27:45 UTC) #7
Message was sent while issue was closed. 
Change committed as 262875

Powered by Google App Engine
This is Rietveld 408576698