Revert of Move more of webcore_remaining into GN build files.

Revert of Move more of webcore_remaining into GN build files. (patchset #2 id:20001 of https://codereview.chromium.org/2301383003/ )

Reason for revert:
Trying to get https://codereview.chromium.org/2308953002/ to apply

Original issue's description:
> Move more of webcore_remaining into GN build files.
>
> This makes more GN build files for various subdirectories of core and adds the
> file lists from the .gypi to those files.
>
> Since there are now so many places requring WebCOre boilerplate, this adds a
> new template for defining core components that automatically does most setup.
> This also cleans up the existing callers.
>
> Committed: https://crrev.com/988d6c9ee633bd2eea254a108908abd7be7351b2
> Cr-Commit-Position: refs/heads/master@{#416344}

TBR=dpranke@chromium.org,dglazkov@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Committed: https://crrev.com/f129d79df66ae1704a653f4cf871e6ae1d359d65
Cr-Commit-Position: refs/heads/master@{#416438}

[Nico, 2016-09-03 03:28:55]

The CQ bit was checked by thakis@chromium.org

[Nico, 2016-09-03 03:28:56]

Created Revert of Move more of webcore_remaining into GN build files.

[commit-bot: I haz the power, 2016-09-03 03:29:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-03 03:30:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-03 03:32:58]

Description was changed from

==========
Revert of Move more of webcore_remaining into GN build files. (patchset #2
id:20001 of https://codereview.chromium.org/2301383003/ )

Reason for revert:
Trying to get https://codereview.chromium.org/2308953002/ to apply

Original issue's description:
> Move more of webcore_remaining into GN build files.
> 
> This makes more GN build files for various subdirectories of core and adds the
> file lists from the .gypi to those files.
> 
> Since there are now so many places requring WebCOre boilerplate, this adds a
> new template for defining core components that automatically does most setup.
> This also cleans up the existing callers.
> 
> Committed: https://crrev.com/988d6c9ee633bd2eea254a108908abd7be7351b2
> Cr-Commit-Position: refs/heads/master@{#416344}

TBR=dpranke@chromium.org,dglazkov@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Revert of Move more of webcore_remaining into GN build files. (patchset #2
id:20001 of https://codereview.chromium.org/2301383003/ )

Reason for revert:
Trying to get https://codereview.chromium.org/2308953002/ to apply

Original issue's description:
> Move more of webcore_remaining into GN build files.
>
> This makes more GN build files for various subdirectories of core and adds the
> file lists from the .gypi to those files.
>
> Since there are now so many places requring WebCOre boilerplate, this adds a
> new template for defining core components that automatically does most setup.
> This also cleans up the existing callers.
>
> Committed: https://crrev.com/988d6c9ee633bd2eea254a108908abd7be7351b2
> Cr-Commit-Position: refs/heads/master@{#416344}

TBR=dpranke@chromium.org,dglazkov@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Committed: https://crrev.com/f129d79df66ae1704a653f4cf871e6ae1d359d65
Cr-Commit-Position: refs/heads/master@{#416438}
==========

[commit-bot: I haz the power, 2016-09-03 03:33:00]

Patchset 1 (id:??) landed as
https://crrev.com/f129d79df66ae1704a653f4cf871e6ae1d359d65
Cr-Commit-Position: refs/heads/master@{#416438}

[brettw, 2016-09-04 05:19:57]

I really really wish you had pinged me before reverting thousands of lines of
diffs across many patches. This is a one line fix and will take me many many
hours to reland.

[Nico, 2016-09-04 14:55:03]

Here's an exhaustive list of changes in blink that landed since the revert:
[]

I don't see how rebasing over 0 patches is going to take many many hours.

On Sun, Sep 4, 2016 at 1:19 AM, <brettw@chromium.org> wrote:

> I really really wish you had pinged me before reverting thousands of lines
> of
> diffs across many patches. This is a one line fix and will take me many
> many
> hours to reland.
>
> https://codereview.chromium.org/2304353002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Nico, 2016-09-04 14:55:03]

Here's an exhaustive list of changes in blink that landed since the revert:
[]

I don't see how rebasing over 0 patches is going to take many many hours.

On Sun, Sep 4, 2016 at 1:19 AM, <brettw@chromium.org> wrote:

> I really really wish you had pinged me before reverting thousands of lines
> of
> diffs across many patches. This is a one line fix and will take me many
> many
> hours to reland.
>
> https://codereview.chromium.org/2304353002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Dirk Pranke, 2016-09-06 01:05:39]

(lgtm)

[brettw, 2016-09-06 17:25:51]

On 2016/09/04 14:55:03, Nico (away until Tuesday) wrote:
> Here's an exhaustive list of changes in blink that landed since the revert:
> []
> 
> I don't see how rebasing over 0 patches is going to take many many hours.

I have a large pipeline of dependent patches which got reset due to this. For
such a simple error for a bot not even on trybots, I would appreciate a ping
next time.