Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2304323002: Cast InternalMap to Map. (Closed)

Created:
4 years, 3 months ago by Bob Nystrom
Modified:
4 years, 3 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cast InternalMap to Map. It's a tag interface that doesn't declare that it implements Map but all classes that implement it also implement Map, so just do a cast. R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/8c7dd5cd042536f1664db7eafdd6b4b3bb25de5c

Patch Set 1 #

Patch Set 2 : Update input SDK file. #

Patch Set 3 : Make InternalMap directly implement Map instead of casting. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -49 lines) Patch
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 1 2 11 chunks +20 lines, -10 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 1 2 11 chunks +20 lines, -10 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 1 2 11 chunks +20 lines, -10 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 1 2 11 chunks +20 lines, -10 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/patch/collection_patch.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/isolate_serialization.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/js_helper.dart View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/linked_hash_map.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/tool/sdk_expected_errors.txt View 1 2 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bob Nystrom
4 years, 3 months ago (2016-09-02 22:31:41 UTC) #2
vsm
lgtm Is there a reason we don't require InternalMap to implement Map? Consistency with dart2js?
4 years, 3 months ago (2016-09-06 21:21:16 UTC) #3
Bob Nystrom
On 2016/09/06 21:21:16, vsm wrote: > lgtm > > Is there a reason we don't ...
4 years, 3 months ago (2016-09-07 22:52:22 UTC) #4
vsm
lgtm
4 years, 3 months ago (2016-09-08 22:12:45 UTC) #5
Bob Nystrom
4 years, 3 months ago (2016-09-08 23:23:42 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
8c7dd5cd042536f1664db7eafdd6b4b3bb25de5c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698