cc: Use SkMScalar instead of doubles everywhere in cc

ui/gfx/transform.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GFX_TRANSFORM_H_
 #define UI_GFX_TRANSFORM_H_
 
 #include <string>
 
 #include "base/compiler_specific.h"
@@ skipping 22 matching lines @@
   // Skips initializing this matrix to avoid overhead, when we know it will be
   // initialized before use.
   Transform(SkipInitialization)
       : matrix_(SkMatrix44::kUninitialized_Constructor) {}
   Transform(const Transform& rhs) : matrix_(rhs.matrix_) {}
   // Initialize with the concatenation of lhs * rhs.
   Transform(const Transform& lhs, const Transform& rhs)
       : matrix_(lhs.matrix_, rhs.matrix_) {}
   // Constructs a transform from explicit 16 matrix elements. Elements
   // should be given in row-major order.
-  Transform(double col1row1, double col2row1, double col3row1, double col4row1,
-            double col1row2, double col2row2, double col3row2, double col4row2,
-            double col1row3, double col2row3, double col3row3, double col4row3,
-            double col1row4, double col2row4, double col3row4, double col4row4);
+  Transform(SkMScalar col1row1,
+            SkMScalar col2row1,
+            SkMScalar col3row1,
+            SkMScalar col4row1,
+            SkMScalar col1row2,
+            SkMScalar col2row2,
+            SkMScalar col3row2,
+            SkMScalar col4row2,
+            SkMScalar col1row3,
+            SkMScalar col2row3,
+            SkMScalar col3row3,
+            SkMScalar col4row3,
+            SkMScalar col1row4,
+            SkMScalar col2row4,
+            SkMScalar col3row4,
+            SkMScalar col4row4);
   // Constructs a transform from explicit 2d elements. All other matrix
   // elements remain the same as the corresponding elements of an identity
   // matrix.
-  Transform(double col1row1, double col2row1,
-            double col1row2, double col2row2,
-            double x_translation, double y_translation);
+  Transform(SkMScalar col1row1,
+            SkMScalar col2row1,
+            SkMScalar col1row2,
+            SkMScalar col2row2,
+            SkMScalar x_translation,
+            SkMScalar y_translation);
   ~Transform() {}
 
   bool operator==(const Transform& rhs) const { return matrix_ == rhs.matrix_; }
   bool operator!=(const Transform& rhs) const { return matrix_ != rhs.matrix_; }
 
   // Resets this transform to the identity transform.
   void MakeIdentity() { matrix_.setIdentity(); }
 
   // Applies the current transformation on a 2d rotation and assigns the result
   // to |this|.
   void Rotate(double degrees) { RotateAboutZAxis(degrees); }
 
   // Applies the current transformation on an axis-angle rotation and assigns
   // the result to |this|.
   void RotateAboutXAxis(double degrees);
   void RotateAboutYAxis(double degrees);
   void RotateAboutZAxis(double degrees);
   void RotateAbout(const Vector3dF& axis, double degrees);
 
   // Applies the current transformation on a scaling and assigns the result
   // to |this|.
-  void Scale(double x, double y);
-  void Scale3d(double x, double y, double z);
+  void Scale(SkMScalar x, SkMScalar y);
+  void Scale3d(SkMScalar x, SkMScalar y, SkMScalar z);
 
   // Applies the current transformation on a translation and assigns the result
   // to |this|.
-  void Translate(double x, double y);
-  void Translate3d(double x, double y, double z);
+  void Translate(SkMScalar x, SkMScalar y);
+  void Translate3d(SkMScalar x, SkMScalar y, SkMScalar z);
 
   // Applies the current transformation on a skew and assigns the result
   // to |this|.
-  void SkewX(double angle_x);
-  void SkewY(double angle_y);
+  void SkewX(SkMScalar angle_x);
+  void SkewY(SkMScalar angle_y);
 
   // Applies the current transformation on a perspective transform and assigns
   // the result to |this|.
-  void ApplyPerspectiveDepth(double depth);
+  void ApplyPerspectiveDepth(SkMScalar depth);
 
   // Applies a transformation on the current transformation
   // (i.e. 'this = this * transform;').
   void PreconcatTransform(const Transform& transform);
 
   // Applies a transformation on the current transformation
   // (i.e. 'this = transform * this;').
   void ConcatTransform(const Transform& transform);
 
   // Returns true if this is the identity matrix.
   bool IsIdentity() const { return matrix_.isIdentity(); }
 
   // Returns true if the matrix is either identity or pure translation.
   bool IsIdentityOrTranslation() const {
     return !(matrix_.getType() & ~SkMatrix44::kTranslate_Mask);
   }
 
   // Returns true if the matrix is either a positive scale and/or a translation.
   bool IsPositiveScaleOrTranslation() const {
     if (!IsScaleOrTranslation())
       return false;
-    return matrix_.getDouble(0, 0) > 0.0 &&
-        matrix_.getDouble(1, 1) > 0.0 &&
-        matrix_.getDouble(2, 2) > 0.0;
+    return matrix_.get(0, 0) > 0.0 && matrix_.get(1, 1) > 0.0 &&
+           matrix_.get(2, 2) > 0.0;
   }
 
   // Returns true if the matrix is either identity or pure, non-fractional
   // translation.
   bool IsIdentityOrIntegerTranslation() const;
 
   // Returns true if the matrix is has only scaling and translation components.
   bool IsScaleOrTranslation() const {
     int mask = SkMatrix44::kScale_Mask | SkMatrix44::kTranslate_Mask;
     return (matrix_.getType() & ~mask) == 0;
@@ skipping 71 matching lines @@
 
   // Decomposes |this| and |from|, interpolates the decomposed values, and
   // sets |this| to the reconstituted result. Returns false if either matrix
   // can't be decomposed. Uses routines described in this spec:
   // http://www.w3.org/TR/css3-3d-transforms/.
   //
   // Note: this call is expensive since we need to decompose the transform. If
   // you're going to be calling this rapidly (e.g., in an animation) you should
   // decompose once using gfx::DecomposeTransforms and reuse your
   // DecomposedTransform.
-  bool Blend(const Transform& from, double progress);
+  bool Blend(const Transform& from, SkMScalar progress);

[danakj, 2013/09/09 17:57:45]

progress isn't a transform element, should stay as double?

 
   // Returns |this| * |other|.
   Transform operator*(const Transform& other) const {
     return Transform(*this, other);
   }
 
   // Sets |this| = |this| * |other|
   Transform& operator*=(const Transform& other) {
     PreconcatTransform(other);
     return *this;
@@ skipping 13 matching lines @@
                               Point3F& point) const;
 
   SkMatrix44 matrix_;
 
   // copy/assign are allowed.
 };
 
 }  // namespace gfx
 
 #endif  // UI_GFX_TRANSFORM_H_