cc: Use SkMScalar instead of doubles everywhere in cc

cc/base/math_util.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_BASE_MATH_UTIL_H_
 #define CC_BASE_MATH_UTIL_H_
 
 #include <algorithm>
 #include <cmath>
 
@@ skipping 18 matching lines @@
 namespace cc {
 
 struct HomogeneousCoordinate {
   HomogeneousCoordinate(SkMScalar x, SkMScalar y, SkMScalar z, SkMScalar w) {
     vec[0] = x;
     vec[1] = y;
     vec[2] = z;
     vec[3] = w;
   }
 
   bool ShouldBeClipped() const { return w() <= 0.0; }

[danakj, 2013/09/09 17:57:45]

We're going to be left in this weird limbo world with integer, float, and double
literals being used for matrix values. I really don't know what's best though,
other than maybe making a rule to use float everywhere? Or use ints and floats?
Or??

The animation code used mostly integer literals, this code uses doubles. Over
time I'm sure we'll see floats if we change SkMScalar to float.

 
   gfx::PointF CartesianPoint2d() const {
     if (w() == 1.0)
       return gfx::PointF(x(), y());
 
     // For now, because this code is used privately only by MathUtil, it should
     // never be called when w == 0, and we do not yet need to handle that case.
     DCHECK(w());
-    double inv_w = 1.0 / w();
+    SkMScalar inv_w = 1.0 / w();
     return gfx::PointF(x() * inv_w, y() * inv_w);
   }
 
   gfx::Point3F CartesianPoint3d() const {
     if (w() == 1)
       return gfx::Point3F(x(), y(), z());
 
     // For now, because this code is used privately only by MathUtil, it should
     // never be called when w == 0, and we do not yet need to handle that case.
     DCHECK(w());
-    double inv_w = 1.0 / w();
+    SkMScalar inv_w = 1.0 / w();
     return gfx::Point3F(x() * inv_w, y() * inv_w, z() * inv_w);
   }
 
   SkMScalar x() const { return vec[0]; }
   SkMScalar y() const { return vec[1]; }
   SkMScalar z() const { return vec[2]; }
   SkMScalar w() const { return vec[3]; }
 
   SkMScalar vec[4];
 };
@@ skipping 105 matching lines @@
 
   // Returns a base::Value representation of the floating point value.
   // If the value is inf, returns max double/float representation.
   static scoped_ptr<base::Value> AsValueSafely(double value);
   static scoped_ptr<base::Value> AsValueSafely(float value);
 };
 
 }  // namespace cc
 
 #endif  // CC_BASE_MATH_UTIL_H_