cc: Use SkMScalar instead of doubles everywhere in cc

cc/animation/transform_operations.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/animation/transform_operations.h"
 
 #include <algorithm>
 
 #include "ui/gfx/box_f.h"
 #include "ui/gfx/transform_util.h"
@@ skipping 17 matching lines @@
 TransformOperations::~TransformOperations() {
 }
 
 gfx::Transform TransformOperations::Apply() const {
   gfx::Transform to_return;
   for (size_t i = 0; i < operations_.size(); ++i)
     to_return.PreconcatTransform(operations_[i].matrix);
   return to_return;
 }
 
-gfx::Transform TransformOperations::Blend(
-    const TransformOperations& from, double progress) const {
+gfx::Transform TransformOperations::Blend(const TransformOperations& from,
+                                          SkMScalar progress) const {

[danakj, 2013/09/09 17:57:45]

progress should be a double?

[enne (OOO), 2013/09/10 22:32:32]

I think an SkMScalar.

   gfx::Transform to_return;
   BlendInternal(from, progress, &to_return);
   return to_return;
 }
 
 bool TransformOperations::BlendedBoundsForBox(const gfx::BoxF& box,
                                               const TransformOperations& from,
-                                              double min_progress,
-                                              double max_progress,
+                                              SkMScalar min_progress,

[danakj, 2013/09/09 17:57:45]

progress should remain as doubles, no? it did elsewhere.

[enne (OOO), 2013/09/10 22:32:32]

SkMScalar, as elsewhere.

+                                              SkMScalar max_progress,
                                               gfx::BoxF* bounds) const {
   *bounds = box;
 
   bool from_identity = from.IsIdentity();
   bool to_identity = IsIdentity();
   if (from_identity && to_identity)
     return true;
 
   if (!MatchesTypes(from))
     return false;
@@ skipping 35 matching lines @@
 
   return true;
 }
 
 bool TransformOperations::CanBlendWith(
     const TransformOperations& other) const {
   gfx::Transform dummy;
   return BlendInternal(other, 0.5, &dummy);
 }
 
-void TransformOperations::AppendTranslate(double x, double y, double z) {
+void TransformOperations::AppendTranslate(SkMScalar x,
+                                          SkMScalar y,
+                                          SkMScalar z) {
   TransformOperation to_add;
   to_add.matrix.Translate3d(x, y, z);
   to_add.type = TransformOperation::TransformOperationTranslate;
   to_add.translate.x = x;
   to_add.translate.y = y;
   to_add.translate.z = z;
   operations_.push_back(to_add);
   decomposed_transform_dirty_ = true;
 }
 
-void TransformOperations::AppendRotate(double x, double y, double z,
-                                       double degrees) {
+void TransformOperations::AppendRotate(SkMScalar x,
+                                       SkMScalar y,
+                                       SkMScalar z,
+                                       SkMScalar degrees) {
   TransformOperation to_add;
   to_add.matrix.RotateAbout(gfx::Vector3dF(x, y, z), degrees);
   to_add.type = TransformOperation::TransformOperationRotate;
   to_add.rotate.axis.x = x;
   to_add.rotate.axis.y = y;
   to_add.rotate.axis.z = z;
   to_add.rotate.angle = degrees;
   operations_.push_back(to_add);
   decomposed_transform_dirty_ = true;
 }
 
-void TransformOperations::AppendScale(double x, double y, double z) {
+void TransformOperations::AppendScale(SkMScalar x, SkMScalar y, SkMScalar z) {
   TransformOperation to_add;
   to_add.matrix.Scale3d(x, y, z);
   to_add.type = TransformOperation::TransformOperationScale;
   to_add.scale.x = x;
   to_add.scale.y = y;
   to_add.scale.z = z;
   operations_.push_back(to_add);
   decomposed_transform_dirty_ = true;
 }
 
-void TransformOperations::AppendSkew(double x, double y) {
+void TransformOperations::AppendSkew(SkMScalar x, SkMScalar y) {
   TransformOperation to_add;
   to_add.matrix.SkewX(x);
   to_add.matrix.SkewY(y);
   to_add.type = TransformOperation::TransformOperationSkew;
   to_add.skew.x = x;
   to_add.skew.y = y;
   operations_.push_back(to_add);
   decomposed_transform_dirty_ = true;
 }
 
-void TransformOperations::AppendPerspective(double depth) {
+void TransformOperations::AppendPerspective(SkMScalar depth) {
   TransformOperation to_add;
   to_add.matrix.ApplyPerspectiveDepth(depth);
   to_add.type = TransformOperation::TransformOperationPerspective;
   to_add.perspective_depth = depth;
   operations_.push_back(to_add);
   decomposed_transform_dirty_ = true;
 }
 
 void TransformOperations::AppendMatrix(const gfx::Transform& matrix) {
   TransformOperation to_add;
   to_add.matrix = matrix;
   to_add.type = TransformOperation::TransformOperationMatrix;
   operations_.push_back(to_add);
   decomposed_transform_dirty_ = true;
 }
 
 void TransformOperations::AppendIdentity() {
   operations_.push_back(TransformOperation());
 }
 
 bool TransformOperations::IsIdentity() const {
   for (size_t i = 0; i < operations_.size(); ++i) {
     if (!operations_[i].IsIdentity())
       return false;
   }
   return true;
 }
 
 bool TransformOperations::BlendInternal(const TransformOperations& from,
-                                        double progress,
+                                        SkMScalar progress,

[danakj, 2013/09/09 17:57:45]

progress as double?

                                         gfx::Transform* result) const {
   bool from_identity = from.IsIdentity();
   bool to_identity = IsIdentity();
   if (from_identity && to_identity)
     return true;
 
   if (MatchesTypes(from)) {
     size_t num_operations =
         std::max(from_identity ? 0 : from.operations_.size(),
                  to_identity ? 0 : operations_.size());
@@ skipping 30 matching lines @@
       decomposed_transform_.reset(new gfx::DecomposedTransform());
     gfx::Transform transform = Apply();
     if (!gfx::DecomposeTransform(decomposed_transform_.get(), transform))
       return false;
     decomposed_transform_dirty_ = false;
   }
   return true;
 }
 
 }  // namespace cc