Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2304273002: WIP RasterCanvasLayerAllocator experiment 2

Created:
4 years, 3 months ago by tomhudson
Modified:
4 years, 2 months ago
Reviewers:
f(malita), reed2
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WIP RasterCanvasLayerAllocator experiment 2 Encapsulates allocating and freeing the raster backing for a canvas. Allows a client's subclass to provide a situationally-appropriate backing: a BITMAP on Windows, a CGBitmapContext on Mac, on Linux a cairo_surface_t. depends on https://codereview.chromium.org/2309483002 BUG=skia:3940

Patch Set 1 #

Patch Set 2 : increment towards full-featured design #

Patch Set 3 : seems to work on cairo chrome #

Patch Set 4 : support initial data? #

Patch Set 5 : remove flush #

Patch Set 6 : SkManagedBitmapDevice #

Patch Set 7 : remove free(), obsolete version of allocateLayer() #

Patch Set 8 : Start removing skia-backed implementation #

Patch Set 9 : chromecast implementation, deviceless SupportsPlatformPaint() #

Patch Set 10 : sketch Windows implementation #

Patch Set 11 : update to Skia patchset 13 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+447 lines, -461 lines) Patch
M skia/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 3 chunks +8 lines, -7 lines 0 comments Download
M skia/ext/bitmap_platform_device.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/bitmap_platform_device_cairo.h View 1 2 1 chunk +0 lines, -113 lines 0 comments Download
M skia/ext/bitmap_platform_device_cairo.cc View 1 2 1 chunk +0 lines, -176 lines 0 comments Download
D skia/ext/bitmap_platform_device_skia.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -59 lines 0 comments Download
D skia/ext/bitmap_platform_device_skia.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -69 lines 0 comments Download
A skia/ext/layer_allocator.h View 1 chunk +22 lines, -0 lines 0 comments Download
A skia/ext/layer_allocator_cairo.h View 1 2 3 4 5 6 7 8 9 1 chunk +47 lines, -0 lines 0 comments Download
A skia/ext/layer_allocator_cairo.cc View 1 2 3 4 5 6 1 chunk +112 lines, -0 lines 0 comments Download
A skia/ext/layer_allocator_win.h View 1 2 3 4 5 6 7 8 9 1 chunk +49 lines, -0 lines 0 comments Download
A skia/ext/layer_allocator_win.cc View 1 2 3 4 5 6 7 8 9 1 chunk +105 lines, -0 lines 0 comments Download
M skia/ext/platform_canvas.h View 1 2 3 4 5 6 7 8 9 10 5 chunks +6 lines, -3 lines 0 comments Download
M skia/ext/platform_canvas.cc View 1 2 3 4 5 6 7 8 9 10 5 chunks +97 lines, -19 lines 0 comments Download
D skia/ext/platform_device_linux.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
tomhudson
For now ignore layer_allocator_skia; only layer_allocator_cairo is getting compiled on Linux.
4 years, 3 months ago (2016-09-16 13:18:06 UTC) #1
tomhudson
4 years, 2 months ago (2016-09-28 21:39:22 UTC) #5 
Unfortunately after updating to
https://codereview.chromium.org/2309483002/#ps240001, although Skia-native unit
tests work, something in the Chrome skia_unittests has broken.

Powered by Google App Engine
This is Rietveld 408576698