Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2304243002: Deflake css3/filter/effect layout tests (Closed)

Created:
4 years, 3 months ago by enne (OOO)
Modified:
4 years, 3 months ago
Reviewers:
pdr., Stephen White
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deflake css3/filter/effect layout tests https://codereview.chromium.org/1960543002 introduced some flakiness in these tests, which appears to be due to texture sampling flakiness in Mesa. One workaround for this is to resize the bitmap in the tests to be 256x128. Because the tile (and the tile draw quad) will use this size directly (instead of rounding up to some other size), the tile and the render pass share the same size and are nice round numbers, so texture sampling should have no errors. BUG=621892 Committed: https://crrev.com/3950059021388215d3864e552c7da761d4c3f822 Cr-Commit-Position: refs/heads/master@{#418428}

Patch Set 1 #

Patch Set 2 : Add the image too oops #

Patch Set 3 : With rebaselines #

Patch Set 4 : With comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+624 lines, -366 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/filters/effect-brightness-clamping-hw.html View 1 2 3 1 chunk +18 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/filters/effect-brightness-hw.html View 1 2 3 1 chunk +14 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/filters/effect-grayscale-hw.html View 1 2 3 1 chunk +13 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/filters/effect-hue-rotate-hw.html View 1 2 3 1 chunk +13 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/filters/effect-saturate-hw.html View 1 2 3 1 chunk +13 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/filters/effect-sepia-hw.html View 1 2 3 1 chunk +13 lines, -6 lines 0 comments Download
A + third_party/WebKit/LayoutTests/css3/filters/resources/reference_square.png View 1 Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/css3/filters/effect-brightness-clamping-hw-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/css3/filters/effect-brightness-hw-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/css3/filters/effect-grayscale-hw-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/css3/filters/effect-hue-rotate-hw-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/css3/filters/effect-saturate-hw-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/css3/filters/effect-sepia-hw-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-brightness-clamping-hw-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-brightness-clamping-hw-expected.txt View 1 2 1 chunk +58 lines, -46 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-brightness-hw-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-brightness-hw-expected.txt View 1 2 1 chunk +28 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-grayscale-hw-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-grayscale-hw-expected.txt View 1 2 1 chunk +24 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-hue-rotate-hw-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-hue-rotate-hw-expected.txt View 1 2 1 chunk +24 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-saturate-hw-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-saturate-hw-expected.txt View 1 2 1 chunk +24 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-sepia-hw-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-sepia-hw-expected.txt View 1 2 1 chunk +24 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-brightness-clamping-hw-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-brightness-clamping-hw-expected.txt View 1 2 1 chunk +58 lines, -46 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-brightness-hw-expected.txt View 1 2 1 chunk +28 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-grayscale-hw-expected.txt View 1 2 1 chunk +24 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-hue-rotate-hw-expected.txt View 1 2 1 chunk +24 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-saturate-hw-expected.txt View 1 2 1 chunk +24 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-sepia-hw-expected.txt View 1 2 1 chunk +24 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-brightness-clamping-hw-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-brightness-clamping-hw-expected.txt View 1 2 1 chunk +58 lines, -46 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-brightness-hw-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-brightness-hw-expected.txt View 1 2 1 chunk +28 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-grayscale-hw-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-grayscale-hw-expected.txt View 1 2 1 chunk +24 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-hue-rotate-hw-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-hue-rotate-hw-expected.txt View 1 2 1 chunk +24 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-saturate-hw-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-saturate-hw-expected.txt View 1 2 1 chunk +24 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-sepia-hw-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-sepia-hw-expected.txt View 1 2 1 chunk +24 lines, -12 lines 0 comments Download

Messages

Total messages: 25 (15 generated)
enne (OOO)
PTAL
4 years, 3 months ago (2016-09-02 21:37:36 UTC) #9
enne (OOO)
PTAL
4 years, 3 months ago (2016-09-02 21:37:37 UTC) #10
pdr.
On 2016/09/02 at 21:37:37, enne wrote: > PTAL Kinda unfortunate but I don't see a ...
4 years, 3 months ago (2016-09-02 21:59:14 UTC) #12
enne (OOO)
On 2016/09/02 at 21:59:14, pdr wrote: > On 2016/09/02 at 21:37:37, enne wrote: > > ...
4 years, 3 months ago (2016-09-02 22:06:41 UTC) #13
pdr.
On 2016/09/02 at 22:06:41, enne wrote: > On 2016/09/02 at 21:59:14, pdr wrote: > > ...
4 years, 3 months ago (2016-09-02 22:19:45 UTC) #14
enne (OOO)
On 2016/09/02 at 22:19:45, pdr wrote: > LGTM here, but please wait for senorblanco to ...
4 years, 3 months ago (2016-09-12 20:28:00 UTC) #15
Stephen White
LGTM
4 years, 3 months ago (2016-09-13 17:56:23 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2304243002/60001
4 years, 3 months ago (2016-09-13 22:49:49 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-14 00:11:57 UTC) #23
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 00:14:41 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3950059021388215d3864e552c7da761d4c3f822
Cr-Commit-Position: refs/heads/master@{#418428}

Powered by Google App Engine
This is Rietveld 408576698