Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: Source/core/inspector/InspectorDOMAgent.cpp

Issue 23042005: [oilpan] Fix iterators over member collections to return Result<T> (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/heap/Handle.h » ('j') | Source/heap/Handle.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved.
4 * Copyright (C) 2009 Joseph Pecoraro 4 * Copyright (C) 2009 Joseph Pecoraro
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 m_elements->add(element); 210 m_elements->add(element);
211 if (!m_timer.isActive()) 211 if (!m_timer.isActive())
212 m_timer.startOneShot(0); 212 m_timer.startOneShot(0);
213 } 213 }
214 214
215 void RevalidateStyleAttributeTask::onTimer(Timer<RevalidateStyleAttributeTask>*) 215 void RevalidateStyleAttributeTask::onTimer(Timer<RevalidateStyleAttributeTask>*)
216 { 216 {
217 // The timer is stopped on m_domAgent destruction, so this method will never be called after m_domAgent has been destroyed. 217 // The timer is stopped on m_domAgent destruction, so this method will never be called after m_domAgent has been destroyed.
218 CollectionRoot<Vector<Member<Element> > > elements; 218 CollectionRoot<Vector<Member<Element> > > elements;
219 for (HashSet<Member<Element> >::iterator it = m_elements->begin(), end = m_e lements->end(); it != end; ++it) 219 for (HashSet<Member<Element> >::iterator it = m_elements->begin(), end = m_e lements->end(); it != end; ++it)
220 elements->append(it->handle().raw()); 220 elements->append((*it).handle().raw());
221 m_domAgent->styleAttributeInvalidated(*elements); 221 m_domAgent->styleAttributeInvalidated(*elements);
222 222
223 m_elements->clear(); 223 m_elements->clear();
224 } 224 }
225 225
226 String InspectorDOMAgent::toErrorString(const ExceptionCode& ec) 226 String InspectorDOMAgent::toErrorString(const ExceptionCode& ec)
227 { 227 {
228 if (ec) { 228 if (ec) {
229 ExceptionCodeDescription description(ec); 229 ExceptionCodeDescription description(ec);
230 return description.name; 230 return description.name;
(...skipping 1590 matching lines...) Expand 10 before | Expand all | Expand 10 after
1821 1821
1822 InjectedScript injectedScript = m_injectedScriptManager->injectedScriptFor(m ainWorldScriptState(frame)); 1822 InjectedScript injectedScript = m_injectedScriptManager->injectedScriptFor(m ainWorldScriptState(frame));
1823 if (injectedScript.hasNoValue()) 1823 if (injectedScript.hasNoValue())
1824 return 0; 1824 return 0;
1825 1825
1826 return injectedScript.wrapNode(node, objectGroup); 1826 return injectedScript.wrapNode(node, objectGroup);
1827 } 1827 }
1828 1828
1829 } // namespace WebCore 1829 } // namespace WebCore
1830 1830
OLDNEW
« no previous file with comments | « no previous file | Source/heap/Handle.h » ('j') | Source/heap/Handle.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698