Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2304173002: [Merge to M54] TabManager: Set OOM scores via a new debugd interface on ChromeOS. (Closed)

Created:
4 years, 3 months ago by Luis Héctor Chávez
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, oshima+watch_chromium.org, hashimoto+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[Merge to M54] TabManager: Set OOM scores via a new debugd interface on ChromeOS. Setting OOM scores generally requires root permission. In the past it's done 1. For Chrome processes: via a SUID binary chrome-sandbox. 2. For Andorid processes: Send scores to Android via IPC. Android handles the rest. Now a new method is added to debugd dbus interface on ChromeOS to handle OOM score settings. https://chromium-review.googlesource.com/#/c/366154/ So we can set OOM score settings in the unified way on ChromeOS. BUG=643212 BUG=b:30193036 TEST=minnie Review-Url: https://codereview.chromium.org/2247433002 Cr-Commit-Position: refs/heads/master@{#414693} (cherry picked from commit 2af9aaceb40213973d0c989de413d0505afefbce) TBR=stevenjb,hashimoto,georgesak Committed: https://chromium.googlesource.com/chromium/src/+/ce6382cfe05ce556f5d1f592dee6875e87a7d343

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -186 lines) Patch
M chrome/browser/memory/tab_manager_delegate_chromeos.h View 8 chunks +7 lines, -26 lines 0 comments Download
M chrome/browser/memory/tab_manager_delegate_chromeos.cc View 14 chunks +102 lines, -152 lines 0 comments Download
M chrome/browser/memory/tab_manager_delegate_chromeos_unittest.cc View 4 chunks +8 lines, -5 lines 0 comments Download
M chromeos/dbus/debug_daemon_client.h View 2 chunks +15 lines, -0 lines 0 comments Download
M chromeos/dbus/debug_daemon_client.cc View 6 chunks +38 lines, -3 lines 0 comments Download
M chromeos/dbus/fake_debug_daemon_client.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chromeos/dbus/fake_debug_daemon_client.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
Luis Héctor Chávez
4 years, 3 months ago (2016-09-02 15:21:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ce6382cfe05ce556f5d1f592dee6875e87a7d343 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698