Issue 230413005: remove sprintf

Issue 230413005: remove sprintf (Closed)

Created:
6 years, 8 months ago by hal.canary

Modified:
5 years, 8 months ago

Reviewers:
mtklein

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

remove sprintf Committed: http://code.google.com/p/skia/source/detail?r=14123

Patch Set 1 : AnotherPatchSet #

Total comments: 4

Patch Set 2 : AnotherPatchSet #

Patch Set 3 : AnotherPatchSet #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
	M	platform_tools/android/launcher/skia_launcher.cpp	View	1 2	2 chunks	+6 lines, -1 line	0 comments	Download
	M	src/core/SkError.cpp	View	1	2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

mtklein

https://codereview.chromium.org/230413005/diff/20001/platform_tools/android/launcher/skia_launcher.cpp File platform_tools/android/launcher/skia_launcher.cpp (right): https://codereview.chromium.org/230413005/diff/20001/platform_tools/android/launcher/skia_launcher.cpp#newcode12 platform_tools/android/launcher/skia_launcher.cpp:12: #define SNPRINTF _snprintf Or just, #define snprintf _snprintf, with ...

6 years, 8 months ago (2014-04-09 20:49:40 UTC) #2

hal.canary

6 years, 8 months ago (2014-04-09 21:38:49 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/230413005/40001

6 years, 8 months ago (2014-04-09 21:44:00 UTC) #5

mtklein

6 years, 8 months ago (2014-04-09 23:38:47 UTC) #7

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/232323002/ by mtklein@google.com.

The reason for reverting is: Boo, hiss, SK_ARRAY_COUNT not defined in
skia_launcher.cpp!.

Expand Messages | Collapse Messages